Update imports so tests can be run externally like mint #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakashsvmx
force-pushed
the
run-func-test-external
branch
3 times, most recently
from
02431d0 to
38c6cc9
Compare
prakashsvmx
force-pushed
the
run-func-test-external
branch
from
cf13534 to
ba50486
Compare
aldy505
reviewed
May 23, 2023
| @@ -25,20 +25,22 @@ import * as url from 'node:url' | |||
| import async from 'async' | |||
| import chai from 'chai' | |||
| import _ from 'lodash' | |||
| import { AssumeRoleProvider } from 'minio/dist/main/AssumeRoleProvider.js' | |||
| import { CopyDestinationOptions, CopySourceOptions, DEFAULT_REGION } from 'minio/dist/main/helpers.js' | |||
| import * as minio from 'minio/dist/main/minio.js' | |||
There was a problem hiding this comment.
We should start importing the source code minio/src/main/minio.ts instead of importing the dist output.
Should adjust mocha to able to parse typescript files too, though.
|
No need to update test files. https://github.com/minio/mint/pull/356/files install rm -rf "/minio-js"
git clone https://github.com/minio/minio-js.git "minio-js"
cd "/minio-js"
LATEST=$(git tag | tail -1)
git checkout "${LATEST}" --force
npm irun test npm --prefix ./minio-js/ run --silent functional -- -R ./minioreporter.js -b --exit 1>>"$output_log_file" 2>"$error_log_file" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update imports so tests can be run externally like mint
How to test locally ( within this repo)
External test:
prakashsvmx/minio-mint-js#1