Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure default expiration parameter is set for presigned URLs #1313

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

bdalpe
Copy link
Contributor

@bdalpe bdalpe commented Jun 26, 2024

Resolves #1312

Additionally, remove unnecessary isFunction checks as that is now handled by the callbackify wrapper.

Added module in unit test library for better coverage.

This is handled by the callbackify wrapper

Signed-off-by: Brendan Dalpe <[email protected]>
Signed-off-by: Brendan Dalpe <[email protected]>
Signed-off-by: Brendan Dalpe <[email protected]>
@prakashsvmx
Copy link
Member

@bdalpe , Thank you, could you please resolve the lint/format issues ?

Signed-off-by: Brendan Dalpe <[email protected]>
@bdalpe
Copy link
Contributor Author

bdalpe commented Jun 26, 2024

@prakashsvmx update pushed to fix the formatting issue in the test

@prakashsvmx prakashsvmx merged commit 2032731 into minio:master Jul 2, 2024
10 checks passed
@septatrix
Copy link
Contributor

This is quite a significant breakage. Could we please get a bugfix release ASAP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X-Amz-Expires should be a number
4 participants