Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add URL encoding processing to the object_name in the URL #84

Closed
wants to merge 1 commit into from
Closed

Add URL encoding processing to the object_name in the URL #84

wants to merge 1 commit into from

Conversation

chenenjie
Copy link

No description provided.

chenenjie
chenenjie commented Apr 12, 2024
View reviewed changes
Copy link
Author

@chenenjie chenenjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use urlencoding crate which haven imported to process object_name

@donatello
Copy link
Member

Thanks for the PR, but on testing it is not correct/complete. We will be closing this one in favor of #86

@donatello donatello closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenenjie @donatello