Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix test #2202

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Hotfix test #2202

merged 1 commit into from
Jul 6, 2024

Conversation

pjuarezd
Copy link
Member

@pjuarezd pjuarezd commented Jul 5, 2024

Adds a test to verify hotfixes can be applied to MinIO tenant.

Updates from minio/RELEASE.2024-02-04T22-36-13Z to minio/RELEASE.2024-02-04T22-36-13Z.hotfix.c40028f8f

Verifies #2190 is solved and prevent regression

@pjuarezd pjuarezd self-assigned this Jul 5, 2024
harshavardhana
harshavardhana previously approved these changes Jul 5, 2024
cniackz
cniackz previously approved these changes Jul 5, 2024
@cniackz cniackz requested a review from dvaldivia July 5, 2024 19:36
@pjuarezd pjuarezd dismissed stale reviews from cniackz and harshavardhana via 3135e0a July 5, 2024 19:46
@harshavardhana
Copy link
Member

Some issue here

removing the admin-mc pod
Error from server (NotFound): pods "admin-mc" not found
/home/runner/work/operator/operator/testing/deploy-cert-manager-tenant.sh: cannot kubectl delete pod admin-mc
Deleting cluster "kind" ...
Deleted nodes: ["kind-worker3" "kind-worker2" "kind-control-plane" "kind-worker" "kind-worker4"]

@pjuarezd
Copy link
Member Author

pjuarezd commented Jul 5, 2024

Some issue here

removing the admin-mc pod
Error from server (NotFound): pods "admin-mc" not found
/home/runner/work/operator/operator/testing/deploy-cert-manager-tenant.sh: cannot kubectl delete pod admin-mc
Deleting cluster "kind" ...
Deleted nodes: ["kind-worker3" "kind-worker2" "kind-control-plane" "kind-worker" "kind-worker4"]

That error is already fixed, and the test is passing in my local consistenly.

Is just that timeouts when running on github action, so I am adding waits and checks to make it more reliable, sorry for the noisy notifications @harshavardhana

Signed-off-by: pjuarezd <[email protected]>
@pjuarezd pjuarezd force-pushed the hotfix-test branch 2 times, most recently from 3a096b5 to 94bac20 Compare July 6, 2024 06:23
@harshavardhana harshavardhana merged commit b70bfee into minio:master Jul 6, 2024
64 checks passed
@pjuarezd pjuarezd deleted the hotfix-test branch July 16, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants