[delete] bench object from listing the bucket #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauspost
reviewed
Dec 6, 2023
fatpat
force-pushed
the
delete-listing
branch
from
d0258f9 to
b45cd94
Compare
I agree, were should I put the factorized code ? |
fatpat
force-pushed
the
delete-listing
branch
from
b45cd94 to
7f77842
Compare
fatpat
force-pushed
the
delete-listing
branch
2 times, most recently
from
5c6164d to
98d1954
Compare
backport listing feature from get to delete when doing a delete bench, during the prepare phase, instead of putting objects in the bucket use the objects already in there. This can be used to bench a specific use case with an already filled in bucket. New options: --list-existing to activate the listing bucket (current behaviour remains) --list-flat: disable recursive listing
fatpat
force-pushed
the
delete-listing
branch
from
98d1954 to
347285c
Compare
harshavardhana
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport listing feature from get to delete
when doing a delete bench, during the prepare phase, instead of putting objects in the bucket use the objects already in there. This can be used to bench a specific use case with an already filled in bucket.
New options:
--list-existing to activate the listing bucket (current
behaviour remains)
--list-flat: disable recursive listing