Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tags to irsa module #27842

Merged
merged 6 commits into from
Nov 15, 2024
Merged

added tags to irsa module #27842

merged 6 commits into from
Nov 15, 2024

Conversation

JazJax
Copy link
Contributor

@JazJax JazJax commented Nov 14, 2024

No description provided.

@JazJax JazJax requested a review from a team as a code owner November 14, 2024 15:39
@cloud-platform-concourse-bot

This PR requires approval from the Cloud Platform team. Please wait for a member of the team to review.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@cloud-platform-concourse-bot

This PR requires approval from the Cloud Platform team. Please wait for a member of the team to review.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@JazJax JazJax force-pushed the EM-datastore-dev-create-irsa branch from 90a3be0 to 58dbe0d Compare November 15, 2024 12:31
@cloud-platform-concourse-bot

This PR requires approval from the Cloud Platform team. Please wait for a member of the team to review.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 6 to be created, 0 to be destroyed, 0 to be updated, 0 to be replaced and 11 unchanged.

Resources to create:

+ aws_iam_policy.athena_access
+ kubernetes_secret.irsa
+ module.irsa.kubernetes_service_account.generated_sa
+ module.irsa.module.iam_assumable_role.aws_iam_role.this[0]
+ module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["athena"]
+ module.irsa.random_id.id

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 6 to be created, 0 to be destroyed, 0 to be updated, 0 to be replaced and 11 unchanged.

Resources to create:

+ aws_iam_policy.athena_access
+ kubernetes_secret.irsa
+ module.irsa.kubernetes_service_account.generated_sa
+ module.irsa.module.iam_assumable_role.aws_iam_role.this[0]
+ module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["athena"]
+ module.irsa.random_id.id

@JazJax JazJax merged commit fa126f3 into main Nov 15, 2024
14 checks passed
@JazJax JazJax deleted the EM-datastore-dev-create-irsa branch November 15, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants