Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter ES query exact match params for altered 'underscore search' performance #149

Conversation

tom-webber
Copy link
Contributor

@tom-webber tom-webber commented Jun 7, 2024

Underscores within exact search in DataHub don't return the expected results. A suggestion from the DataHub Slack is:

setting the environment variable ELASTICSEARCH_QUERY_EXACT_MATCH_EXCLUSIVE to true in the GMS causes exact matches with underscores to behave as expected.

This leads to more results than expected - another response suggested:

[try] disabling ELASTICSEARCH_QUERY_EXACT_MATCH_WITH_PREFIX to achieve the desired result

This PR adopts those suggestions

…E and disable ELASTICSEARCH_QUERY_EXACT_MATCH_WITH_PREFIX to achieve expected underscore search behaviour
@LavMatt
Copy link
Contributor

LavMatt commented Oct 21, 2024

Going to close this as i think what Mitch has done in later releases of datahub supersede this

@LavMatt LavMatt closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants