fixup: remove primary key from csv

We don't show this in the UI because it's not populated reliably, so we shouldn't included it in the csv either.
ministryofjustice · Nov 8, 2024 · efcf56c · efcf56c
1 parent c572030
commit efcf56c
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/home/service/details_csv.py b/home/service/details_csv.py
@@ -14,7 +14,6 @@ def data(self):
             (
                 column.name,
                 column.display_name,
-                column.is_primary_key,
                 column.type,
                 column.nullable,
                 column.description,
@@ -26,7 +25,6 @@ def headers(self):
         return [
             "name",
             "display_name",
-            "is_primary_key",
             "type",
             "nullable",
             "description",

diff --git a/tests/home/service/test_details_csv.py b/tests/home/service/test_details_csv.py
@@ -41,7 +41,6 @@ def test_dataset_details_csv_formatter(example_table):
     assert csv_formatter.headers() == [
         "name",
         "display_name",
-        "is_primary_key",
         "type",
         "nullable",
         "description",
@@ -50,15 +49,13 @@ def test_dataset_details_csv_formatter(example_table):
         (
             "foo",
             "Foo",
-            True,
             "string",
             False,
             "an example",
         ),
         (
             "bar",
             "Bar",
-            False,
             "integer",
             True,
             "another example",

diff --git a/tests/test_views.py b/tests/test_views.py
@@ -68,8 +68,8 @@ def test_csv_output(self, client):
             response.headers["Content-Disposition"] == 'attachment; filename="fake.csv"'
         )
         assert response.content == (
-            b"name,display_name,is_primary_key,type,nullable,description\r\n"
-            + b"urn,urn,True,string,False,description **with markdown**\r\n"
+            b"name,display_name,type,nullable,description\r\n"
+            + b"urn,urn,string,False,description **with markdown**\r\n"
         )