-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata items to tables and databases (CaDeT) #1040
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murdo-moj
changed the title
Add metadata items to tables and databases
Add metadata items to tables and databases (CaDeT)
Nov 12, 2024
MatMoore
reviewed
Nov 13, 2024
MatMoore
reviewed
Nov 13, 2024
lib/datahub-client/data_platform_catalogue/client/graphql_helpers.py
Outdated
Show resolved
Hide resolved
MatMoore
reviewed
Nov 15, 2024
MatMoore
reviewed
Nov 15, 2024
murdo-moj
commented
Nov 15, 2024
lib/datahub-client/data_platform_catalogue/client/graphql_helpers.py
Outdated
Show resolved
Hide resolved
MatMoore
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added metadata items
Provider: Analytical PlatformWe don't know what provider means. The audience item tells users if they can share data or not.Data last updatedTemporarily hidden until the run_results are reliableChanged
Questions for reviewers:
Is it worth making Audience and Provider an Enum type?I have done this