-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add selenium tests #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this is currently failing!
Will add selenium tests as a separate job
This configuration triggers - when stuff is merged into main (or directly pushed) - when a PR is raised against main (internal or via a fork)
murdo-moj
reviewed
Feb 14, 2024
might we want to disable screenshots from the workflow job? we can't see any of the screenshots on the runner |
murdo-moj
reviewed
Feb 14, 2024
murdo-moj
reviewed
Feb 14, 2024
Co-authored-by: Murdo <[email protected]>
murdo-moj
reviewed
Feb 15, 2024
murdo-moj
reviewed
Feb 15, 2024
Co-authored-by: Murdo <[email protected]>
Co-authored-by: Murdo <[email protected]>
murdo-moj
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some selenium tests, using pytest-django's live_server fixture (equivalent to Django's LiveServerTestCase)
Selenium can be really fiddly, and I don't want these tests to slow us down, so would welcome any suggestions on how to make them easy to maintain.
(Note: the commit history is messy so this is best reviewed all together)
Details
Mocking
This is using the global mock @murdo-moj added for the catalogue, so the tests don't depend on datahub to run.
Structure
I've applied the page object pattern so that all the selectors are in one place, so if we change the template we can change that without rewriting the whole test class.
Each step in a test extracted to a helper method so we can reuse them for multiple scenarios.
Utilities
I've included some utilities to make this more useful:
CI
Selenium tests are quite slow, so I've made it a separate step that runs only if the unit tests pass. It uses a headless chrome browser, which is installed by default on the ubuntu runner.
Fixes
In the process of adding these tests, I've fixed a couple of html issues such as missing labels, multiple main sections, elements appearing outside of a landmark region.