-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find-moj-data-45/search-highlighting #78
Conversation
murdo-moj
commented
Feb 19, 2024
•
edited
Loading
edited
- Add a matched fields entry to search results with readable names
- Apply bold highlighting for search terms on the description and search summary fields
- The search summary field isn't actually searched by datahub, it's more of a patch until we figure out how we want to handle long descriptions
- Should URN/ID even be included in matched fields? Users will not care about it's URN or ID most likely.
I agree we can ignore matching on URN and ID |
I added back ID and URN, as otherwise some search results had blank match reasons. I've also displayed a clipped search description instead of a search summary on the search page. Pre-existing markdown will likely cause some weird rendering on the descriptions, but I couldn't think of a nice way around it other than restricting inputs for the descriptions. I've tested the highlighted descriptions with a screenreader; it doesn't pick up the bolding. Jeremy points out that this isn't that important as highlighting is for visual acuity rather than screenreaders. |