[LAA-APPLY-FOR-CRIMINAL-LEGAL-AID-3X] fix validation issues #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiboabd
reviewed
Sep 9, 2024
mseedat-moj
suggested changes
Oct 18, 2024
| end | ||
| errors | ||
| end | ||
| # rubocop:enable Metrics/MethodLength |
There was a problem hiding this comment.
I think this method can be simplified to something like:
value = begin
Kernel.Float(send(attribute))
rescue ArgumentError, TypeError
nil
end
return [:not_a_number] if value.nil?
options.map do { |option, arg| validate_numericality_option(option, arg, value) }.compact
Haven't tried it though.
| case option | ||
| when :greater_than | ||
| :greater_than if value <= arg | ||
| end |
There was a problem hiding this comment.
Not sure how this is working - is the idea that it's just a method confirming the greater_than error really is a greater_than error?
| @@ -50,6 +50,6 @@ def error_message(obj, error) | |||
| "#{obj.model_name.i18n_key}.summary.#{error.attribute}.#{error.type}", | |||
| scope: [:activemodel, :errors, :models], | |||
| payment_type: payment_type | |||
| ) | |||
| ).capitalize | |||
There was a problem hiding this comment.
Does capitalize uppercase every first character in each word?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Ensure that numericality validation messages on the Income Payment form have all the necessary information to construct an error message.
Link to relevant ticket
LAA-APPLY-FOR-CRIMINAL-LEGAL-AID-3X
Notes for reviewer
I've implemented a custom numericality validation method in order to have more control over the error messaging, i.e. to be able to provide the
payment_typevalue to the error strings. The need for this comes from content changes that require more dynamic field-level error messaging - e.g. "Maintenance payments amount must be greater than 0" instead of "Amount must be greater than 0". Previously, these "fuller" error messages were only shown in the error summary box.Initially I wanted to extend the default
NumericalityValidatorwhich does all the validation we could want, but I couldn't find a good way to extend it just so I could alter the error messaging.What's also becoming clear is that we end up constructing error messages both at the attribute level and at the summary level when in most (all?) cases the summary error messages will be the same, just repeated above the form. Unless there are cases where summary errors need to differ from field-level errors, this seems like duplicated effort.