Also test on Chrome for better coverage

minkphp · Jan 13, 2025 · 4d0c9e0 · 4d0c9e0
1 parent 906ea02
commit 4d0c9e0
Showing 1 changed file with 17 additions and 6 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -42,14 +42,25 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        selenium_version: [ '2.53.1' ]
+        selenium_version: '2.53.1'
+        browser: 'firefox'
         php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2' ]
-        with_coverage: [ false ]
+        with_coverage: false
         include:
           - selenium_version: '2.53.1'
+            browser: 'firefox'
             php: '8.3'
             with_coverage: true
           - selenium_version: '3.141.59'
+            browser: 'firefox'
+            php: '8.3'
+            with_coverage: true
+          - selenium_version: '2.53.1'
+            browser: 'chrome'
+            php: '8.3'
+            with_coverage: true
+          - selenium_version: '3.141.59'
+            browser: 'chrome'
             php: '8.3'
             with_coverage: true
       fail-fast: false
@@ -82,7 +93,7 @@ jobs:
 
       - name: Start Selenium
         run: |
-          SELENIUM_IMAGE=selenium/standalone-firefox:${{ matrix.selenium_version }} docker compose up --wait
+          SELENIUM_IMAGE=selenium/standalone-${{ matrix.browser }}:${{ matrix.selenium_version }} docker compose up --wait
 
       - name: Wait for browser & PHP to start
         run: |
@@ -95,7 +106,7 @@ jobs:
           SELENIUM_VERSION: ${{ matrix.selenium_version }}
           DRIVER_URL: http://localhost:4444/wd/hub
           WEB_FIXTURES_HOST: http://host.docker.internal:8002
-          WEB_FIXTURES_BROWSER: firefox
+          WEB_FIXTURES_BROWSER: ${{ matrix.browser }}
           DRIVER_MACHINE_BASE_PATH: /fixtures/
         run: |
           vendor/bin/phpunit -v --coverage-clover=coverage.xml --log-junit junit.xml
@@ -106,7 +117,7 @@ jobs:
           SELENIUM_VERSION: ${{ matrix.selenium_version }}
           DRIVER_URL: http://localhost:4444/wd/hub
           WEB_FIXTURES_HOST: http://host.docker.internal:8002
-          WEB_FIXTURES_BROWSER: firefox
+          WEB_FIXTURES_BROWSER: ${{ matrix.browser }}
           DRIVER_MACHINE_BASE_PATH: /fixtures/
         run: |
           vendor/bin/phpunit -v
@@ -133,6 +144,6 @@ jobs:
         if: ${{ failure() }}
         uses: actions/upload-artifact@v4
         with:
-          name: logs_php-${{ matrix.php }}_selenium-${{ matrix.selenium_version }}_firefox
+          name: logs_php-${{ matrix.php }}_selenium-${{ matrix.selenium_version }}_${{ matrix.browser }}
           path: |
             logs