Fixing build #303

oleg-andreyev · 2019-01-04T09:10:57Z

Closes #290
Closes #287

composer.json

aik099 · 2019-01-04T09:21:16Z

Using Docker as the only way to run tests on Travis CI is too radical solution. Have you tried other things, like locking to other Firefox version or maybe using Google Chrome?

oleg-andreyev · 2019-01-04T09:35:51Z

@aik099 I cannot agree that Docker is a radical solution, it's a de-facto container solution, but yes I have a working solution for Google Chrome, I could apply it, but I wanted to keep as much as possible from master + @stof have a different PR for Google Chrome.

aik099 · 2019-01-04T10:10:47Z

I cannot agree that Docker is a radical solution, it's a de-facto container solution, but yes I have a working solution for Google Chrome, I could apply it, but I wanted to keep as much as possible from master + @stof have a different PR for Google Chrome.

I see, but then why this PR is needed, when you already know that #300 should fix the same thing in a different way?

oleg-andreyev · 2019-01-04T10:34:10Z

Firefox and Chrome are different browsers and MAY behave differently, in ideal I would add testing with firefox / chrome / phantomjs (not supported, but still quite popular), so Docker will be more convenient to use and also it does not cost anything to maintain Docker images.

oleg-andreyev · 2019-01-04T11:17:14Z

BTW ChomeDriver is failing with

1) Behat\Mink\Tests\Driver\Custom\TimeoutTest::testInvalidTimeoutSettingThrowsException
Failed asserting that exception of type "Exception" matches expected exception "\Behat\Mink\Exception\DriverException". Message was: "invalid argument: unknown type of timeout:invalid
  (Session info: chrome=71.0.3578.98)
  (Driver info: chromedriver=2.45.615355 (d5698f682d8b2742017df6c81e0bd8e6a3063189),platform=Mac OS X 10.14.2 x86_64)"

This is because how instaclick/php-webdriver is handling errors

https://github.com/instaclick/php-webdriver/blob/161f35e3c45d9fb93b1171a1394f8d555aab9525/lib/WebDriver/Exception.php#L139

Chrome is returning errno 61, which is not mapped.

composer.json

.travis.yml

aik099 · 2019-01-04T13:51:48Z

Firefox and Chrome are different browsers and MAY behave differently, in ideal I would add testing with firefox / chrome / phantomjs (not supported, but still quite popular), so Docker will be more convenient to use and also it does not cost anything to maintain Docker images.

Probably. OK.

aik099 · 2019-01-04T13:52:23Z

BTW ChomeDriver is failing with
1) Behat\Mink\Tests\Driver\Custom\TimeoutTest::testInvalidTimeoutSettingThrowsException
Failed asserting that exception of type "Exception" matches expected exception "\Behat\Mink\Exception\DriverException". Message was: "invalid argument: unknown type of timeout:invalid
  (Session info: chrome=71.0.3578.98)
  (Driver info: chromedriver=2.45.615355 (d5698f682d8b2742017df6c81e0bd8e6a3063189),platform=Mac OS X 10.14.2 x86_64)" 
This is because how instaclick/php-webdriver is handling errors

https://github.com/instaclick/php-webdriver/blob/161f35e3c45d9fb93b1171a1394f8d555aab9525/lib/WebDriver/Exception.php#L139

Chrome is returning errno 61, which is not mapped.

Any way to fix this? Maybe a PR to InstaClick is needed?

oleg-andreyev · 2019-01-04T14:28:26Z

Any way to fix this? Maybe a PR to InstaClick is needed?

Without making a PR to InstaClick, impossible.
As up to me, InstaClick seems as abandoned there is no activity for a year almost.
Almost all issues are created by @stof or @aik099.
And as I mentioned before I'd like to push forward with facebook/php-webdriver
#304
instaclick/php-webdriver#87

- added docker for php >= 5.4 (trusty) - added php 7.3 - updated README - added DISPLAY env and xvfb for 5.3 (precise)

oleg-andreyev · 2019-01-05T00:41:45Z

Ready. Build green. 5.3 is returned

oleg-andreyev · 2019-01-23T20:16:10Z

@stof @aik099 are there any showstopper for this being merged?

README.md

.travis.yml

oleg-andreyev · 2019-02-18T11:39:23Z

@stof @aik099 is there anything holding us on merging this PR?

aik099 · 2019-02-18T17:23:08Z

Nothing is blocking me. I'm not sure about @stof .

oleg-andreyev · 2019-03-02T21:24:29Z

ping @stof

L0rD59 · 2019-03-07T10:01:19Z

Hi,

I have some trouble with latest release (1.3.1)

Fatal error: Uncaught WebDriver\Exception\UnknownError: Build info: version: '2.48.2', revision: '41bccdd', time: '2015-10-09 19:59:12'
System info: host: '018fc27d0330', ip: '172.31.0.9', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-45-generic', java.version: '1.8.0_45-internal'
Driver info: driver.version: unknown in /var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php on line 350

Call Stack:
    0.0004     362408   1. {main}() /var/www/html/vendor/behat/behat/bin/behat:0
    0.0399    2119624   2. Behat\Testwork\Cli\Application->run() /var/www/html/vendor/behat/behat/bin/behat:34

Behat\Mink\Exception\DriverException: Could not close connection in /var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php on line 350

Call Stack:
    0.0004     362408   1. {main}() /var/www/html/vendor/behat/behat/bin/behat:0
    0.0399    2119624   2. Behat\Testwork\Cli\Application->run() /var/www/html/vendor/behat/behat/bin/behat:34
   98.2076   17677000   3. Behat\Mink\Mink->__destruct() /var/www/html/vendor/behat/mink/src/Mink.php:0
   98.2076   17677000   4. Behat\Mink\Mink->stopSessions() /var/www/html/vendor/behat/mink/src/Mink.php:46
   98.2077   17677000   5. Behat\Mink\Session->stop() /var/www/html/vendor/behat/mink/src/Mink.php:186
   98.2077   17677000   6. Behat\Mink\Driver\Selenium2Driver->stop() /var/www/html/vendor/behat/mink/src/Session.php:78

If i use dev-master works as expected and faster

aik099 · 2019-03-07T10:52:51Z

Hi,

I have some trouble with latest release (1.3.1)

Fatal error: Uncaught WebDriver\Exception\UnknownError: Build info: version: '2.48.2', revision: '41bccdd', time: '2015-10-09 19:59:12'
System info: host: '018fc27d0330', ip: '172.31.0.9', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-45-generic', java.version: '1.8.0_45-internal'
Driver info: driver.version: unknown in /var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php on line 350

Call Stack:
    0.0004     362408   1. {main}() /var/www/html/vendor/behat/behat/bin/behat:0
    0.0399    2119624   2. Behat\Testwork\Cli\Application->run() /var/www/html/vendor/behat/behat/bin/behat:34

Behat\Mink\Exception\DriverException: Could not close connection in /var/www/html/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php on line 350

Call Stack:
    0.0004     362408   1. {main}() /var/www/html/vendor/behat/behat/bin/behat:0
    0.0399    2119624   2. Behat\Testwork\Cli\Application->run() /var/www/html/vendor/behat/behat/bin/behat:34
   98.2076   17677000   3. Behat\Mink\Mink->__destruct() /var/www/html/vendor/behat/mink/src/Mink.php:0
   98.2076   17677000   4. Behat\Mink\Mink->stopSessions() /var/www/html/vendor/behat/mink/src/Mink.php:46
   98.2077   17677000   5. Behat\Mink\Session->stop() /var/www/html/vendor/behat/mink/src/Mink.php:186
   98.2077   17677000   6. Behat\Mink\Driver\Selenium2Driver->stop() /var/www/html/vendor/behat/mink/src/Session.php:78

If i use dev-master works as expected and faster

Hi, @L0rD59 . How your comment is related to changes made in this PR?

oleg-andreyev · 2019-06-14T19:00:54Z

@stof @aik099 if PR is approved can we merge it?

…ded WEB_FIXTURES_HOST for MacOS

oleg-andreyev · 2019-06-22T22:54:03Z

@stof @aik099 I've resumed work on this branch.
I've added php7.4snapshot (and build is passing)
Also I've reused minkphp/driver-testsuite#37 where 5.3 is dropped.

https://travis-ci.org/minkphp/MinkSelenium2Driver/builds/549208858

oleg-andreyev · 2019-08-11T14:07:23Z

@aik099 @stof can we make this moving?

composer.json

phpunit.xml.dist

oleg-andreyev · 2019-08-28T13:12:17Z

@aik099 build is green.

aik099 · 2019-08-28T17:27:08Z

Merging. Thanks @oleg-andreyev .

aik099 reviewed Jan 4, 2019

View reviewed changes

composer.json Show resolved Hide resolved

aik099 requested changes Jan 4, 2019

View reviewed changes

composer.json Show resolved Hide resolved

.travis.yml Outdated Show resolved Hide resolved

.travis.yml Outdated Show resolved Hide resolved

.travis.yml Outdated Show resolved Hide resolved

.travis.yml Outdated Show resolved Hide resolved

fixing travis build

ba7fad4

- added docker for php >= 5.4 (trusty) - added php 7.3 - updated README - added DISPLAY env and xvfb for 5.3 (precise)

oleg-andreyev force-pushed the fix-master-build branch from d06ee2a to ba7fad4 Compare January 5, 2019 00:06

oleg-andreyev mentioned this pull request Jan 5, 2019

[WIP] Facebook driver #304

Closed

stof reviewed Jan 25, 2019

View reviewed changes

README.md Outdated Show resolved Hide resolved

.travis.yml Outdated Show resolved Hide resolved

.travis.yml Show resolved Hide resolved

.travis.yml Outdated Show resolved Hide resolved

.travis.yml Show resolved Hide resolved

oleg-andreyev added 3 commits January 25, 2019 22:14

updated README.md

62fe5d4

updated .travis.yml

e6bcfe1

added comment to travis

4d9c724

aik099 approved these changes Feb 18, 2019

View reviewed changes

oleg-andreyev added 4 commits June 22, 2019 22:23

removed 5.3 support, reusing dev-drop-php-53-force-phpunit-less-8, ad…

516cf6d

…ded WEB_FIXTURES_HOST for MacOS

forcing 7.3.6

1995cee

changed dist to xenial, added matrix for 5.x and trusty

44afaa0

added 7.4snapshot

ae16cc4

added 7.4snapshot

bfb6ce5

aik099 requested changes Aug 13, 2019

View reviewed changes

composer.json Outdated Show resolved Hide resolved

composer.json Show resolved Hide resolved

composer.json Outdated Show resolved Hide resolved

aik099 reviewed Aug 28, 2019

View reviewed changes

phpunit.xml.dist Show resolved Hide resolved

removed repository override

1a00312

aik099 approved these changes Aug 28, 2019

View reviewed changes

aik099 mentioned this pull request Aug 28, 2019

Attempts to fix currently failing test suite #290

Closed

aik099 merged commit a385124 into minkphp:master Aug 28, 2019

aik099 mentioned this pull request Aug 28, 2019

New version release? #284

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing build #303

Fixing build #303

oleg-andreyev commented Jan 4, 2019 •

edited by aik099

Loading

aik099 commented Jan 4, 2019

oleg-andreyev commented Jan 4, 2019 •

edited

Loading

aik099 commented Jan 4, 2019

oleg-andreyev commented Jan 4, 2019 •

edited

Loading

oleg-andreyev commented Jan 4, 2019 •

edited

Loading

aik099 commented Jan 4, 2019

aik099 commented Jan 4, 2019

oleg-andreyev commented Jan 4, 2019 •

edited

Loading

oleg-andreyev commented Jan 5, 2019

oleg-andreyev commented Jan 23, 2019

oleg-andreyev commented Feb 18, 2019

aik099 commented Feb 18, 2019

oleg-andreyev commented Mar 2, 2019

L0rD59 commented Mar 7, 2019 •

edited

Loading

aik099 commented Mar 7, 2019

oleg-andreyev commented Jun 14, 2019

oleg-andreyev commented Jun 22, 2019

oleg-andreyev commented Aug 11, 2019

oleg-andreyev commented Aug 28, 2019

aik099 commented Aug 28, 2019

Fixing build #303

Fixing build #303

Conversation

oleg-andreyev commented Jan 4, 2019 • edited by aik099 Loading

aik099 commented Jan 4, 2019

oleg-andreyev commented Jan 4, 2019 • edited Loading

aik099 commented Jan 4, 2019

oleg-andreyev commented Jan 4, 2019 • edited Loading

oleg-andreyev commented Jan 4, 2019 • edited Loading

aik099 commented Jan 4, 2019

aik099 commented Jan 4, 2019

oleg-andreyev commented Jan 4, 2019 • edited Loading

oleg-andreyev commented Jan 5, 2019

oleg-andreyev commented Jan 23, 2019

oleg-andreyev commented Feb 18, 2019

aik099 commented Feb 18, 2019

oleg-andreyev commented Mar 2, 2019

L0rD59 commented Mar 7, 2019 • edited Loading

aik099 commented Mar 7, 2019

oleg-andreyev commented Jun 14, 2019

oleg-andreyev commented Jun 22, 2019

oleg-andreyev commented Aug 11, 2019

oleg-andreyev commented Aug 28, 2019

aik099 commented Aug 28, 2019

oleg-andreyev commented Jan 4, 2019 •

edited by aik099

Loading

oleg-andreyev commented Jan 4, 2019 •

edited

Loading

oleg-andreyev commented Jan 4, 2019 •

edited

Loading

oleg-andreyev commented Jan 4, 2019 •

edited

Loading

oleg-andreyev commented Jan 4, 2019 •

edited

Loading

L0rD59 commented Mar 7, 2019 •

edited

Loading