-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "docker-composer.yml" file during the build #406
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #406 +/- ##
============================================
+ Coverage 85.45% 85.85% +0.39%
Complexity 182 182
============================================
Files 1 1
Lines 502 502
============================================
+ Hits 429 431 +2
+ Misses 73 71 -2 ☔ View full report in Codecov by Sentry. |
@uuf6429 , do you have an idea why this doesn't work? When Selenium tries to load the http://host.docker.internal:8002/js_test.html page from the Docker container it gets the |
@aik099 my first guess would be something related to config, since the xml files are also a bit different:
How I would troubleshoot it:
|
3c4eb4e
to
360d6b0
Compare
Thank you. The
That fixed Selenium 2 image usage, however, the Selenium 3 images keep failing with a different error. |
c7c9029
to
93152d9
Compare
The Selenium 3 build is also fixed now. Turned out, that the Selenium 3 container took a bit longer to start (then Selenium 2) and @uuf6429 , Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment - looks good otherwise.
Ported some changes from
webdriver-classic-driver
.