Skip to content

Commit

Permalink
Use CodeCov Flags
Browse files Browse the repository at this point in the history
  • Loading branch information
aik099 committed Jan 10, 2025
1 parent fb117d5 commit c1261b1
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: coverage.xml
flags: ${{ matrix.browser }}-${{ matrix.selenium }}

- name: Upload test results to Codecov
# See https://nektosact.com/usage/index.html#skipping-steps
Expand Down
29 changes: 28 additions & 1 deletion tests/WebdriverClassicConfig.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,39 @@ public static function getInstance(): self

public function createDriver(): WebdriverClassicDriver
{
$browser = $this->getBrowserName();
$seleniumHost = $_SERVER['DRIVER_URL'] ?? null;
if (!is_string($seleniumHost)) {
throw new \RuntimeException('Selenium host must be specified (as a string) in $_SERVER[DRIVER_URL].');
}

return new WebdriverClassicDriver($this->getBrowserName(), [], $seleniumHost);
/*return new WebdriverClassicDriver(
'firefox',
array(
'build' => 'MinkSelenium2Driver Tests - Selenium2 Setting Detection',
'browserstack.local' => 'true',
'browserstack.localIdentifier' => 'nativeapp:4C090194-181B-5979-B7AF-9067377E0A18',
'acceptInsecureCerts' => true,
// 'version' => 92, // Doesn't work.
'version' => 47, // Works.
),
'http://aik099:[email protected]/wd/hub'
);*/

return new WebdriverClassicDriver(
$browser,
array(
'goog:chromeOptions' => array(
'binary' => '/Applications/Brave Browser.app/Contents/MacOS/Brave Browser',
'args' => array(
'disable-features=MacAppCodeSignClone',
),
),
),
$seleniumHost
);

return new WebdriverClassicDriver($browser, [], $seleniumHost);
}

public function getBrowserName(): string
Expand Down

0 comments on commit c1261b1

Please sign in to comment.