Add 4* Special Rate to Sim #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DTM9025 <[email protected]>
This is the first iteration of taking into account the effect 4* Special Rates have on summoning. Right now this assumes the rate always starts at 3% (which has always been the case so far) and the pools for 3* and 4* units are the same (which is currently the case). This doesn't include 4* Special Hero Special Rates, which would add another 3* rate to the table. Given that this particular rate is very rare as opposed to the normal 4* Special Rate, that will be for later.
In adding the new 4* Special Rate pool, I made an error in getting the pity rate adjustments, mistakenly dividing the proportion by a further 100 which messed it up and made the 4* Special Rate seem to have an outsize impact on the sims despite that shouldn't being the case. This fixes this error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first iteration of taking into account the effect
4* Special Rates have on summoning. Right now this assumes the
rate always starts at 3% (which has always been the case so far)
and the pools for 3* and 4* units are the same (which is currently
the case).
This doesn't include 4* Special Hero Special Rates, which would
add another 3* rate to the table. Given that this particular rate
is very rare as opposed to the normal 4* Special Rate (only appears
on old seasonal reruns) and would need some mechanism to turn
it on, I forwent that for now.