-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hints #84
Merged
Merged
Hints #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Several new settings have been created that allow for the creation of hints to help guide players on where to go in their playthroughs.
There are several types of hints that players can choose to create. Each hint type has its own setting where players can select anywhere between 0-7 of each type.
Types of Hints
Path Hints:
Barren Hints:
Item Hints:
Location Hints:
Hint Placement Options
There are two hint placement options that players can select for distributing the above kinds of hints.
Fi Hints:
Gossip Stone Hints:
excluded_locations
listPlayers can select none, one, or both hint placement options. If both are selected, the total number of hints will be divided equally between the placement options. So if there are 14 total hints, Fi will get 7, and the gossip stones as a whole will get 7.
Other Types of Hints
Song Hints:
basic
will only indicate if a major item can be found.advanced
will indicate if a required item can be found.direct
will directly state what major item(s) are in the silent realm.direct
setting will directly state what is believed to be the most useful item in the silent realm followed by how many other major items there are. Example: The realm beyond holds the Clawshots and 2 more items. This is done due to limited text space on the inventory screen not being able to show all the listed items if we listed them all individually.Impa Stone of Trials Hint:
Cryptic Hints:
Always Hints:
Text Data
This PR also changes how we internally handle the text for text patches and moves all current text data into
data/text_data/english.yaml
. For potential support of other languages in the future, we can add files such asspanish.yaml
orjapanese.yaml
for supporting in-game text in other languages. Internally, all patches that need text must store the associated text in thetext_table
inutil/text.py
. This way, we can more easily patch multiple languages at once in the future if/when it becomes necessary.How do you test this changes?
I generated a few seeds and read the text in-game and it all looked correct and matched with the generated Spoiler Log. A few more tests were also added to the pytest suite.