Fix connection timeout error, add example #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 23, 2014 17:46
- Added configurable username/password fields - Made LDAP connection get created on auth attempts otherwise the connection can be closed by the LDAP server and break the strategy unless the application is restarted - Added username placeholder replace
- Add contributors
Closed
|
Awesome, thanks! I'll test it over the weekend and get it merged. |
|
Sorry, realized just now that I had changed the Also prettied up the readme up a bit and documented the |
mintbridge
added a commit
that referenced
this pull request
May 1, 2014
Fix connection timeout error, add example Thanks @EnzoMartin78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the LDAP connection can timeout/get closed by the LDAP server due to idle time which will break the Strategy from working unless the application is restarted.
Adds the ability to configure the username/password field to use from the request, and adds support for replacing the placeholder string in the configured filter. (#7)
I've also added a Windows LDAP example. (#4)
Tested with a Windows AD server