-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: improve settings and environment logic and phase out redundant environment keys #3384
Conversation
Signed-off-by: Donny Peeters <[email protected]>
Signed-off-by: Donny Peeters <[email protected]>
Signed-off-by: Donny Peeters <[email protected]>
Signed-off-by: Donny Peeters <[email protected]>
Signed-off-by: Donny Peeters <[email protected]>
…e/improve-settings-env-logic
…e/improve-settings-env-logic
…e/improve-settings-env-logic
…e/improve-settings-env-logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Btw; this is very much related to #1906, any possibility we could discuss this one soon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
For the next iteration, I suggest we start using pytest markers to distinguish between different test types (e.g., unit, integration, and performance tests). This approach will help us avoid using code/environment guards and streamline the CI process
Checklist for QA:
What works:Functionally this PR seems to work as expected. I enabled some general boefjes (onboarding + nmap ports) and they run. I also enabled LeaxIX with an API key and this runs as well, including the normalizers. What doesn't work:The docs have some room for improvement on how a user can work with the environment keys. Based on the initial ticket I would say you have to do the following: Add Bug or feature?:n/a |
Signed-off-by: Donny Peeters <[email protected]>
Signed-off-by: Donny Peeters <[email protected]>
@stephanie0x00 Done :) |
Changes
This improves the environment logic to pass all BOEFJES_* environment variables to the boefjes and allows you to override them with the KATalogus settings. This makes the flow more simple and intuitive.
Issue link
Closes #3356
Demo
QA notes
Please verify the Katalogus and boefjes such as
dns-records
still work properly, creating settings and review the documentation update.Code Checklist
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.