Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always redirect to katalogus when enabling plugins #3584

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

noamblitz
Copy link
Contributor

@noamblitz noamblitz commented Sep 26, 2024

Changes

Before, when enabling/disabling plugins we tried redirecting back, this caused problems in the report flow where post requests are used. Now, after discussions with @underdarknl we decided that enabling/disabling plugins would always redirect to the katalogus page. It is then the responsibility of the user to go back to the report flow.

Issue link

You have to create an issue to link to this PR. If this really is not possible, write a very detailed description here and add this PR to the project board directly.

Please add the link to the issue after "Closes".

Closes ...

Demo

Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.

QA notes

  • enabling plugins in katalogus should still work
  • enabling/disabling plugins in report flow should work (but redirect you to the katalogus)

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@noamblitz noamblitz requested a review from a team as a code owner September 26, 2024 11:48
@underdarknl
Copy link
Contributor

In a new ticket we can improve the UX for users by handling these calls trough an optional Async call to a new json api.

@underdarknl underdarknl merged commit 30607f3 into main Sep 30, 2024
10 checks passed
@underdarknl underdarknl deleted the always-redirect-to-katalogus branch September 30, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants