-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: form styling #3588
Merged
Merged
fix: form styling #3588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeleenSG
requested review from
RomijnHumanoids,
stephanie0x00 and
underdarknl
September 26, 2024 15:19
ammar92
approved these changes
Sep 30, 2024
Checklist for QA:
What works:Did not find any unexpected behaviour. Tried to check all the forms I could find and they all look good. The filters are now small long columns, but that is solved with the implementation of the multiselect. What doesn't work:n/a Bug or feature?:n/a |
underdarknl
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates form styling according to new design choices.
Design:
https://www.figma.com/file/MDbpc9K0qjyaoRGAGiDX6t/KAT-%7C-Design-System-%7C-Components?type=design&node-id=529%3A3819&t=GypnIVz3VX7OFn1I-1
Example:
https://www.figma.com/file/sJpcWSngJDWdNPoal21ERe/KAT-%7C-Design-%7C-Workfile?type=design&node-id=1801%3A25829&t=2kfv36PnNt2vaS40-1
Issue link
Closes #1216
Demo
Before:
After:
QA notes
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.