Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form styling #3588

Merged
merged 11 commits into from
Oct 1, 2024
Merged

fix: form styling #3588

merged 11 commits into from
Oct 1, 2024

Conversation

HeleenSG
Copy link
Contributor

@HeleenSG HeleenSG commented Sep 26, 2024

Changes

Updates form styling according to new design choices.

Design:
https://www.figma.com/file/MDbpc9K0qjyaoRGAGiDX6t/KAT-%7C-Design-System-%7C-Components?type=design&node-id=529%3A3819&t=GypnIVz3VX7OFn1I-1

Example:
https://www.figma.com/file/sJpcWSngJDWdNPoal21ERe/KAT-%7C-Design-%7C-Workfile?type=design&node-id=1801%3A25829&t=2kfv36PnNt2vaS40-1

Issue link

Closes #1216

Demo

Before:
Screenshot 2024-09-23 at 17 39 25

After:
Screenshot 2024-09-26 at 16 59 59

QA notes

  • Please check if form is implemented according to new designs (see Figma link at the top of this pr)
  • Please check for any unwanted/weird behaviour or regressions

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@HeleenSG HeleenSG marked this pull request as ready for review September 26, 2024 15:18
@HeleenSG HeleenSG requested a review from a team as a code owner September 26, 2024 15:18
@HeleenSG HeleenSG self-assigned this Sep 26, 2024
@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

Did not find any unexpected behaviour. Tried to check all the forms I could find and they all look good. The filters are now small long columns, but that is solved with the implementation of the multiselect.

What doesn't work:

n/a

Bug or feature?:

n/a

@underdarknl underdarknl merged commit f036693 into main Oct 1, 2024
10 checks passed
@underdarknl underdarknl deleted the fix/form-styling branch October 1, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update forms to new design
4 participants