-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report Schedules List #3608
Merged
Merged
Report Schedules List #3608
Changes from all commits
Commits
Show all changes
317 commits
Select commit
Hold shift + click to select a range
c5d7aae
Continue updating tests
jpbruinsslot 45019f3
Continue with fixing tests
jpbruinsslot 1f46615
Update tests
jpbruinsslot 5275ec4
Fixing tests
jpbruinsslot 88208b4
Fix stalled tests
jpbruinsslot b729d7c
Remove PrioritizedItem
jpbruinsslot 3942029
Updating tests
jpbruinsslot 473199e
Restructure deadline calculation
jpbruinsslot 8f31c61
Start fixing normalizer scheduler
jpbruinsslot cc53a39
Restructure
jpbruinsslot a0f4be6
Remove obsolete code
jpbruinsslot 8c5d7bf
Merge branch 'main' into feature/mula/refactor-queue
jpbruinsslot c90e216
Some more merge conflict fixes
jpbruinsslot 592270f
Update
jpbruinsslot 5aefdb9
Refactor push task
jpbruinsslot 8d29a3e
Refactor
jpbruinsslot 51f40fd
Start with normalizer refactor
jpbruinsslot 4c46160
Todo
jpbruinsslot ee9a234
Refactor push task normalizer
jpbruinsslot 25bfe06
Merge branch 'main' into feature/mula/refactor-queue
jpbruinsslot 064d930
Fix conflict
jpbruinsslot 0c27657
Fix server api tests
jpbruinsslot 35c57bb
Refactor server
jpbruinsslot 44c9b8e
Add api endpoints for schedules
jpbruinsslot 5459ccd
Rename method normalizer scheduler
jpbruinsslot 126ab04
Changes
jpbruinsslot 76ad63e
Trying to fix bug
jpbruinsslot 3cb590f
Update normalizer
jpbruinsslot 8e9b401
Fix validation and setting of schedule
jpbruinsslot 3c1c9d3
Bug finally fixed
jpbruinsslot 4820d1b
Continue fixing bugs
jpbruinsslot c48d93f
Fix retrieving schedules from database
jpbruinsslot d673789
Make tests work
jpbruinsslot f2f7ca9
Fixing bugs, updating tests
jpbruinsslot e9ce420
Fix tests
jpbruinsslot ec03654
Fixing tests
jpbruinsslot 448b580
For now skip test
jpbruinsslot 78e0101
Merge branch 'main' into feature/mula/refactor-queue
jpbruinsslot 6f6836d
Integration scheduler changes with other services
jpbruinsslot 8f18cd6
Fix normalizer bug
jpbruinsslot d566317
Start with schedule implementation
jpbruinsslot 8e358a8
Update and fix scripts
jpbruinsslot 09d8861
Add tests
jpbruinsslot 8e67fe3
Fixes
jpbruinsslot afe8acb
Merge branch 'main' into feature/mula/refactor-queue
jpbruinsslot 64487b4
Add some tests
jpbruinsslot 7a2a938
Update migration
jpbruinsslot b576a2d
Update migrations
jpbruinsslot e68a7e7
Update migrations
jpbruinsslot 64e6820
Fix new boefjes
jpbruinsslot 4405160
Add tests
jpbruinsslot 7fb719e
Remove breakpoint
jpbruinsslot 5b360a5
Precommit
jpbruinsslot 260a2f3
Restructure scripts
jpbruinsslot cd64da4
Restructure storage
jpbruinsslot 395ae2f
Restructure server
jpbruinsslot 81b1a34
Fix new boefjes issue
jpbruinsslot 735d4b4
Merge branch 'feature/mula/refactor-queue' into feature/rocky/schedules
jpbruinsslot 83ef876
Add thread safety tests
jpbruinsslot ba3a81d
Add additional thread safety test for the other caches
jpbruinsslot 7e4ce13
Add more tests
jpbruinsslot d90d6d5
Merge branch 'fix/mula/new_boefjes' into feature/mula/refactor-queue
jpbruinsslot e6c800c
Merge branch 'main' into fix/mula/new_boefjes
underdarknl 88e7bb7
Exclude folder from pre-commit
jpbruinsslot 1d83f0f
Update .pre-commit-config.yaml
jpbruinsslot 8dc860c
Update pyproject.toml
jpbruinsslot 95ed5ed
Update .pre-commit-config.yaml
jpbruinsslot 8c08c9a
Remove logging statements
jpbruinsslot 1a19d77
Precommit
jpbruinsslot 626301d
Merge branch 'main' into feature/mula/server-updates
jpbruinsslot b9553ad
Merge branch 'main' into feature/mula/storage-updates
jpbruinsslot 35fc046
Fix mypy suggestions
jpbruinsslot 51089dd
Update tests
jpbruinsslot e5823be
Update
jpbruinsslot cea7f53
Fix tests
jpbruinsslot b63faa0
Pre-commit
jpbruinsslot ff49bc5
Merge branch 'feature/mula/storage-updates' into feature/mula/refacto…
jpbruinsslot 79c860e
Merge branch 'feature/mula/scripts' into feature/mula/refactor-queue
jpbruinsslot 66c2a16
Pre-commit
jpbruinsslot c446e13
Merge branch 'feature/mula/server-updates' into feature/mula/refactor…
jpbruinsslot e30ba73
Pre-commit
jpbruinsslot 0b45e49
Merge branch 'feature/mula/scripts' into feature/mula/refactor-queue
jpbruinsslot 408227d
Pre-commit
jpbruinsslot 55e4673
Update mula/scheduler/connectors/services/katalogus.py
jpbruinsslot f97b196
Updates according to code-review
jpbruinsslot 019752b
Pre-commit
jpbruinsslot 7cdb525
Update filters.py
jpbruinsslot 093276c
Update logging
jpbruinsslot 33bac6e
Update filters.py
jpbruinsslot 4e1dc9e
Pre-commit
jpbruinsslot da875c5
Fix filters
jpbruinsslot df4855e
Trying to fix mypy errors
jpbruinsslot 9185597
Merge branch 'main' into feature/mula/storage-updates
jpbruinsslot e97a460
Fix datastore connection
jpbruinsslot 0633a06
Trying to fix boefje tests
jpbruinsslot 9bfd16b
Fix boefje tests
jpbruinsslot 5a60394
Merge branch 'main' into fix/mula/new_boefjes
ammar92 de2eef7
Remove unnecessary type hints
jpbruinsslot c560581
Fix rocky tests
jpbruinsslot 494a558
Fix rocky tests
jpbruinsslot ad44c02
Fix rocky tests
jpbruinsslot aa5aa2d
Update filters.py
jpbruinsslot e9950a9
Pre-commit
jpbruinsslot bd1a99e
Fix mypy
jpbruinsslot 86901ab
Trying to add stubs
jpbruinsslot 1fbceb6
Update mula/scheduler/context/context.py
jpbruinsslot 4fbbe42
Update mula/scheduler/context/context.py
jpbruinsslot 875cf08
Updates according to code review
jpbruinsslot 7a78358
Add code-review suggestions
jpbruinsslot 48bd09d
Merge branch 'feature/mula/scripts' into feature/mula/refactor-queue
jpbruinsslot 20654d5
Merge remote-tracking branch 'origin/fix/mula/new_boefjes' into featu…
jpbruinsslot b862117
Merge remote-tracking branch 'origin/feature/mula/server-updates' int…
jpbruinsslot 9f64326
Merge remote-tracking branch 'origin/feature/mula/storage-updates' in…
jpbruinsslot 14fbe54
Merge branch 'main' into feature/mula/refactor-queue
jpbruinsslot aebb870
Fix for boefje/normalizer runner
jpbruinsslot f6be13a
Pre-commit
jpbruinsslot 2516b1b
Fix requirements
jpbruinsslot abf5bf1
Update croniter
jpbruinsslot f777ef3
Update from croniter types
jpbruinsslot dc7f1f4
Ignore type
jpbruinsslot 6ed961f
Ignore security-sensitive check of random
jpbruinsslot beeab12
Fix shadowing of python builtin
jpbruinsslot c849d0a
Pre-commit
jpbruinsslot 00c126d
Fix linting
jpbruinsslot 7926f53
Fix manual rescheduling
jpbruinsslot 4b46b0c
Fix schedule_id when manual rescheduling
jpbruinsslot ce073ea
Merge branch 'feature/mula/refactor-queue' into feature/rocky/schedules
jpbruinsslot 6ee70e9
Merge branch 'main' into feature/mula/refactor-queue
jpbruinsslot 5df88d0
Merge branch 'feature/mula/refactor-queue' into feature/rocky/schedules
jpbruinsslot 69e6faf
Merge branch 'main' into feature/mula/refactor-queue
jpbruinsslot 94a25c5
Merge branch 'feature/mula/refactor-queue' into feature/rocky/schedules
jpbruinsslot 0e4b2fa
Merge branch 'main' into feature/mula/refactor-queue
jpbruinsslot 7371c55
Fix formatting
jpbruinsslot e4daab6
Formatting
jpbruinsslot bfda8fb
Formatting
jpbruinsslot 299fc22
Updates according to code review
jpbruinsslot efb871a
Merge branch 'main' into feature/mula/refactor-queue
jpbruinsslot 50c39a2
Fix poetry
jpbruinsslot c0af1ea
Schedule report forms and validations and corn expressions
Rieven 8efbf8a
Merge branch 'feature/mula/refactor-queue' into feature/rocky/schedules
jpbruinsslot c3a7854
Add form to reports for shculing
Rieven 15087be
Merge branch 'feature/rocky/schedules' of github.com:minvws/nl-kat-co…
Rieven 8b7c3ca
Add api create schedules functionality
jpbruinsslot 6117eec
Merge branch 'feature/mula/api-create-schedules' into feature/rocky/s…
jpbruinsslot 9f0da80
Update create schedule functionality
jpbruinsslot d4408fe
Pre-commit
jpbruinsslot c6f8f9f
Update scheduler client for rocky
jpbruinsslot 265ced6
Fix tests
jpbruinsslot e985caf
Fix test
jpbruinsslot 54ade75
Merge remote-tracking branch 'origin' into feature/rocky/schedules
jpbruinsslot d99d2b5
Add create schedule functionality to api
jpbruinsslot 90ae4c8
Update serializers
jpbruinsslot 9141fbf
Add TODO
jpbruinsslot 2e8937b
Refactor report history
madelondohmen f3a7d3d
Add scheduled report page
madelondohmen fddbaf9
Add validation, and hash generation
jpbruinsslot f4075b9
Table changes
madelondohmen bb968df
Add tests
jpbruinsslot 5f2ee1e
Remove action buttons
madelondohmen 11821ea
Pre-commit
jpbruinsslot 061df46
Merge branch 'main' into feature/mula/create-schedule
jpbruinsslot 978656b
Check if hash already exists
jpbruinsslot ba33e61
Update
jpbruinsslot d585ce3
Merge branch 'main' into feature/mula/create-schedule
jpbruinsslot 819955a
Merge branch 'main' into feature/mula/create-schedule
jpbruinsslot 1bd0c61
Merge branch 'feature/rocky/schedules' of github.com:minvws/nl-kat-co…
Rieven 700db1f
Merge branch 'feature/mula/create-schedule' of github.com:minvws/nl-k…
Rieven 55c5967
Merge branch 'feature/merge-scheduled-reports' of github.com:minvws/n…
Rieven a1cde85
Scheduler api integrated
Rieven 35ebc9c
add schedule
Rieven 57009a2
start with report recipe
Rieven a25d1e4
report recipe setup
Rieven 55b65ed
Report recipe for generate report
Rieven ad1f8d2
Merge branch 'main' of github.com:minvws/nl-kat-coordination into fea…
Rieven 8c4867c
move error messages
Rieven 101af63
Merge branch 'main' of github.com:minvws/nl-kat-coordination into fea…
Rieven d3c2430
Merge branch 'main' of github.com:minvws/nl-kat-coordination into fea…
Rieven 3904028
Merge branch 'main' of github.com:minvws/nl-kat-coordination into fea…
Rieven 2767329
Merge branch 'main' into feature/schedule-report
Rieven 2189e55
Merge branch 'main' into feature/schedule-report
Rieven db5798a
Merge remote-tracking branch 'origin' into feature/schedule-report
jpbruinsslot 5671a0d
Rebase
jpbruinsslot 512b2e9
Update report task
jpbruinsslot 780870e
Remove patch method for now to avoid confusion
jpbruinsslot 881aac8
Merge branch 'main' of github.com:minvws/nl-kat-coordination into fea…
Rieven a59d07b
Merge branch 'feature/report-recipe' of github.com:minvws/nl-kat-coor…
Rieven c047a43
Merge branch 'main' of github.com:minvws/nl-kat-coordination into fea…
Rieven 41232a8
Merge branch 'feature/report-recipe' of github.com:minvws/nl-kat-coor…
Rieven 7092cde
fix lang
Rieven 74cd0b5
Update scheduler client
jpbruinsslot b9ce6b0
fix multi report
Rieven 53c55c7
Merge branch 'feature/schedule-report' of github.com:minvws/nl-kat-co…
Rieven 565ac48
Update
jpbruinsslot 89965be
Fix multi-report
Rieven 1736ced
Merge branch 'main' of github.com:minvws/nl-kat-coordination into fea…
Rieven 18c03e5
Merge branch 'feature/report-recipe' of github.com:minvws/nl-kat-coor…
Rieven 978492d
fix multirepor view
Rieven 8cbcdc8
Merge branch 'feature/report-recipe' of github.com:minvws/nl-kat-coor…
Rieven f1795db
fix lang
Rieven 137f926
Add report type to multireport
Rieven 978f35c
Merge branch 'feature/report-recipe' of github.com:minvws/nl-kat-coor…
Rieven 1c5d262
fix precommit
Rieven 4eac7be
Merge branch 'feature/report-recipe' of github.com:minvws/nl-kat-coor…
Rieven a7b3d0f
fix precommit
Rieven 16298bc
Fix views for aggregate report
Rieven 7f24508
Fix typing
Rieven 19059e6
Fix views and template to prepare repor recipe
Rieven 093236f
Merge branch 'main' of github.com:minvws/nl-kat-coordination into fea…
Rieven 4d346b0
fix test
Rieven 7ff4072
fix precommit
Rieven 7192bb6
fix lang
Rieven 33f635e
Merge branch 'feature/report-recipe' of github.com:minvws/nl-kat-coor…
Rieven 5ea561c
fix test
Rieven 35d7190
Add form
Rieven a591fcf
chaneg names
Rieven 69fd077
add typing
Rieven abd8f7e
Fix form validation for cron
Rieven 5a5dc78
Add report recipe OOI (#3442)
Rieven fde2ff3
Merge branch 'main' of github.com:minvws/nl-kat-coordination into fea…
Rieven 284536f
Merge branch 'main' into feature/scheduled-reports-page
madelondohmen f46ebb1
Fix views for report schedule
Rieven f68be57
Merge branch 'feature/report-recipe' of github.com:minvws/nl-kat-coor…
Rieven 98399df
Get data from scheduler
madelondohmen 683feb8
Merge branch 'main' into feature/scheduled-reports-page
madelondohmen d214896
Add schdule reports
Rieven 5d29d7b
Merge branch 'main' of github.com:minvws/nl-kat-coordination into fea…
Rieven bbc6ecf
Merge branch 'feature/report-recipe' of github.com:minvws/nl-kat-coor…
Rieven e1c28e8
bundled errors
Rieven 806c464
add natural key
noamblitz 2b4e57e
Merge branch 'feature/report-recipe' of github.com:minvws/nl-kat-coor…
Rieven 883eacf
Fix some bug when change selection
Rieven a47f112
Merge branch 'main' into feature/scheduled-reports-page
madelondohmen e0cc588
Add a report runner implementation (#3587)
Donnype a1dcbc2
add text
Rieven 6964e3c
fix test
Rieven 4df40e0
Merge branch 'main' of github.com:minvws/nl-kat-coordination into fea…
Rieven 15343db
Merge branch 'feature/report-recipe' of github.com:minvws/nl-kat-coor…
Rieven 2d8b329
merge base
Rieven f11891f
fix base
Rieven 3afd2ef
fix lang
Rieven cbc81b5
Merge branch 'feature/scheduled-reports-page' of github.com:minvws/nl…
Rieven 94328cf
report schedules list
Rieven a2292bd
add reports to recipe in overview
noamblitz ee5705f
add expando
Rieven 172304b
fix expando
noamblitz 0af8ad2
fix templat
Rieven c22a9b0
Merge branch 'main' of github.com:minvws/nl-kat-coordination into mer…
Rieven 069164c
fix routing for schedules, fix pre-commit
Rieven 9c08de6
fix precommit
Rieven a0f2de4
Merge branch 'main' into merge/report-schedule-page
stephanie0x00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
36 changes: 24 additions & 12 deletions
36
rocky/reports/templates/report_overview/report_history.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,26 @@ | ||
{% extends "layouts/base.html" %} | ||
|
||
{% load i18n %} | ||
{% load static %} | ||
|
||
{% block content %} | ||
{% include "header.html" %} | ||
|
||
<main id="main-content" tabindex="-1" class="katalogus"> | ||
<section> | ||
{% include "report_overview/report_overview_header.html" %} | ||
{% include "report_overview/report_overview_navigation.html" with active="history" %} | ||
|
||
<div class="horizontal-scroll"> | ||
<h2>{% translate "Reports history" %}</h2> | ||
<p>{% translate "An overview of all your generated reports." %}</p> | ||
<p class="de-emphasized"> | ||
{% blocktranslate with length=reports|length total=total_oois %}Showing {{ length }} of {{ total }} reports{% endblocktranslate %} | ||
</p> | ||
{% include "report_overview/report_history_table.html" %} | ||
{% include "partials/list_paginator.html" %} | ||
|
||
<section> | ||
<div class="horizontal-scroll"> | ||
<h2>{% translate "Reports history" %}</h2> | ||
<p>{% translate "An overview of all your generated reports." %}</p> | ||
<p class="de-emphasized"> | ||
{% blocktranslate with length=reports|length total=total_oois %}Showing {{ length }} of {{ total }} reports{% endblocktranslate %} | ||
</p> | ||
{% include "report_overview/report_history_table.html" %} | ||
{% include "partials/list_paginator.html" %} | ||
|
||
</div> | ||
</section> | ||
</div> | ||
</section> | ||
</main> | ||
{% endblock content %} |
16 changes: 0 additions & 16 deletions
16
rocky/reports/templates/report_overview/report_overview.html
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
rocky/reports/templates/report_overview/scheduled_reports.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
{% extends "layouts/base.html" %} | ||
|
||
{% load i18n %} | ||
{% load static %} | ||
|
||
{% block content %} | ||
{% include "header.html" %} | ||
|
||
<main id="main-content" tabindex="-1" class="katalogus"> | ||
<section> | ||
{% include "report_overview/report_overview_header.html" %} | ||
{% include "report_overview/report_overview_navigation.html" with active="scheduled" %} | ||
|
||
<div class="horizontal-scroll"> | ||
<h2>{% translate "Scheduled reports" %}</h2> | ||
<p>{% translate "View your scheduled reports." %}</p> | ||
<p class="de-emphasized"> | ||
{% blocktranslate with length=scheduled_reports|length total=total_oois %}Showing {{ length }} scheduled reports{% endblocktranslate %} | ||
</p> | ||
{% include "report_overview/scheduled_reports_table.html" %} | ||
{% include "partials/list_paginator.html" %} | ||
|
||
</div> | ||
</section> | ||
</main> | ||
{% endblock content %} |
89 changes: 89 additions & 0 deletions
89
rocky/reports/templates/report_overview/scheduled_reports_table.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
{% load i18n %} | ||
{% load ooi_extra %} | ||
{% load report_extra %} | ||
|
||
<div class="horizontal-scroll"> | ||
<table> | ||
<caption class="visually-hidden">{% translate "Scheduled reports:" %}</caption> | ||
<thead> | ||
<tr> | ||
<th scope="col">{% translate "Report Name" %}</th> | ||
<th scope="col">{% translate "Subreport Name" %}</th> | ||
<th scope="col">{% translate "Report types" %}</th> | ||
<th scope="col">{% translate "Scheduled for" %}</th> | ||
<th scope="col">{% translate "Recurrence" %}</th> | ||
<th scope="col"></th> | ||
</tr> | ||
</thead> | ||
<tbody> | ||
{% for schedule in scheduled_reports %} | ||
{% if schedule.recipe %} | ||
<tr> | ||
<td class="nowrap">{{ schedule.recipe.report_name_format }}</td> | ||
<td class="nowrap">{{ schedule.recipe.subreport_name_format }}</td> | ||
<td> | ||
{% for report_type in schedule.recipe.report_types %} | ||
{% if forloop.counter0 < 2 %} | ||
<span class="label tags-color-{{ report_type|get_report_type_label_style }}">{{ report_type|get_report_type_name }}</span> | ||
{% endif %} | ||
{% if forloop.counter0 == 2 %} | ||
<span class="label tags-color-grey-2">+ {{ schedule.recipe.report_types|length|add:"-2" }}</span> | ||
{% endif %} | ||
{% endfor %} | ||
</td> | ||
<td class="nowrap">{{ schedule.deadline_at }}</td> | ||
<td class="nowrap">{{ schedule.cron }}</td> | ||
{% if schedule.reports %} | ||
<td class="actions"> | ||
<button class="expando-button" | ||
data-icon-open-class="icon ti-chevron-down" | ||
data-icon-close-class="icon ti-chevron-up" | ||
data-close-label="{% translate "Close details" %}"> | ||
{% translate "Open details" %} | ||
</button> | ||
</td> | ||
{% else %} | ||
<td></td> | ||
{% endif %} | ||
</tr> | ||
{% if schedule.reports %} | ||
<tr class="expando-row"> | ||
<td colspan="6"> | ||
<table> | ||
<caption class="visually-hidden">{% translate "Scheduled Reports:" %}</caption> | ||
<thead> | ||
<tr> | ||
<th scope="col">{% translate "Name" %}</th> | ||
<th scope="col">{% translate "Report type" %}</th> | ||
<th scope="col">{% translate "Input Object" %}</th> | ||
<th scope="col">{% translate "Reference date" %}</th> | ||
<th scope="col">{% translate "Creation date" %}</th> | ||
</tr> | ||
</thead> | ||
<tbody> | ||
{% for report in schedule.reports %} | ||
<tr> | ||
<td> | ||
<a href="{% url "view_report" organization.code %}?report_id={{ report.reference }}&observed_at={{ report.observed_at|date:"Y-m-d H:i:s:u" }}" | ||
title="{% translate "Show report details" %}">{{ report.name }}</a> | ||
</td> | ||
<td> | ||
<span class="label tags-color-{{ report.report_type|get_report_type_label_style }}">{{ report.report_type|get_report_type_name }}</span> | ||
</td> | ||
<td> | ||
{% for ooi in report.input_oois %}<span>{{ ooi|human_readable }}</span>{% endfor %} | ||
</td> | ||
<td class="nowrap">{{ report.observed_at|date }}</td> | ||
<td class="nowrap">{{ report.date_generated }}</td> | ||
</tr> | ||
{% endfor %} | ||
</tbody> | ||
</table> | ||
</td> | ||
</tr> | ||
{% endif %} | ||
{% endif %} | ||
{% endfor %} | ||
</tbody> | ||
</table> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better for accessibility if these were in a
<ul>
.