Fix settings boefje settings via system env vars

[dekkers]

Changes

Fixes a bug where the BOEFJE prefix was not removed before checking if the environment variable is allowed, resulting in it not allowing any of the environment variables.

QA notes

Fix was already tested yesterday by Z-CERT.

---

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

---

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

[stephanie0x00]

Checklist for QA:

• I have checked out this branch, and successfully ran a fresh make reset.
• I confirmed that there are no unintended functional regressions in this branch:
  • I have managed to pass the onboarding flow
  • Objects and Findings are created properly
  • Tasks are created and completed properly
• I confirmed that the PR's advertised feature or hotfix works as intended.
• I checked the logs for errors and/or warnings and made issues where necessary

What works:

Looks good. Everything seems to work.

What doesn't work:

n/a

Bug or feature?:

n/a

[ammar92]

Nice work. One suggestion, looks good otherwise

[dekkers]

I have pushed a better implementation that fixed a bug in my original change, but should also be easier to understand. It also caches the boefje system env variables, because there is no need to loop over the environment variables everytime a boefje gets executed. There are also unit tests now.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud