Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add searching and sorting to Findings page #3804

Merged
merged 13 commits into from
Nov 12, 2024

Conversation

madelondohmen
Copy link
Contributor

@madelondohmen madelondohmen commented Nov 6, 2024

Changes

This PR's adds the possibility to order the findings table by severity or by finding.
Also, it adds a search filter, which makes it possible to search for the primary key.

Issue link

Closes #3494
Closes #2254

Demo

afbeelding

QA notes

Please add some information for QA on how to test the newly created code.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@madelondohmen madelondohmen requested a review from a team as a code owner November 6, 2024 11:25
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing language update and a broken test (should be an easy one to fix).

Can be QA'd already

@stephanie0x00
Copy link
Contributor

stephanie0x00 commented Nov 7, 2024

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

Love this feature!! Sorting works, also when a filter is applied (e.g. only Medium and Low findings). Searching makes this page so much better.

What doesn't work:

Only improvement I can think of is that the explanation text of the search bar should be updated, as "Object ID contains" is not that user friendly. Maybe we could update the explanation text to something like: "Search for (partial) findings, hosts or IP-addresses. The search functionality is case sensitive. "

Bug or feature?:

n/a

underdarknl
underdarknl previously approved these changes Nov 11, 2024
Copy link

sonarcloud bot commented Nov 12, 2024

@underdarknl underdarknl merged commit 0342a72 into main Nov 12, 2024
21 of 22 checks passed
@underdarknl underdarknl deleted the feature/searching-filtering-findings branch November 12, 2024 12:48
@paulvandenbraken
Copy link

paulvandenbraken commented Nov 14, 2024

After closure of [#3494 ] and reviewing the demo screens, it seems we lack the requested columns (10-okt) in the closed ticket:

"Kennisnet would like to have the ability to see when an object was created and last verified. If we could sort by this information, it would create a sort of journal that tracks objects added over time. This feature would be incredibly helpful, as it allows you to quickly see which items have been added since the last time you checked. This functionality should be available on both the findings page and the objects page, and it would also be great to have a search option for objects on these pages."

Is there a possibility to have this function added to the design?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching and filtering in findings-overview Filtering findings based on Hostname/IP
5 participants