-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add searching and sorting to Findings page #3804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing language update and a broken test (should be an easy one to fix).
Can be QA'd already
Checklist for QA:
What works:Love this feature!! Sorting works, also when a filter is applied (e.g. only Medium and Low findings). Searching makes this page so much better. What doesn't work:Only improvement I can think of is that the explanation text of the search bar should be updated, as "Object ID contains" is not that user friendly. Maybe we could update the explanation text to something like: "Search for (partial) findings, hosts or IP-addresses. The search functionality is case sensitive. " Bug or feature?:n/a |
….com/minvws/nl-kat-coordination into feature/searching-filtering-findings
Quality Gate passedIssues Measures |
After closure of [#3494 ] and reviewing the demo screens, it seems we lack the requested columns (10-okt) in the closed ticket: "Kennisnet would like to have the ability to see when an object was created and last verified. If we could sort by this information, it would create a sort of journal that tracks objects added over time. This feature would be incredibly helpful, as it allows you to quickly see which items have been added since the last time you checked. This functionality should be available on both the findings page and the objects page, and it would also be great to have a search option for objects on these pages." Is there a possibility to have this function added to the design? |
Changes
This PR's adds the possibility to order the findings table by severity or by finding.
Also, it adds a search filter, which makes it possible to search for the primary key.
Issue link
Closes #3494
Closes #2254
Demo
QA notes
Please add some information for QA on how to test the newly created code.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.