-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the keiko report module #4066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, looks good to me. I was just wondering why we still need the version
module? Are there still references to keiko
as a package?
This is used in the CI to build the debian package and container image so we still need it to build the empty package and image. |
|
Checklist for QA:
What works:Seems to work. Can still export reports, not seeing errors in the logs. Couldn't find anything broken caused by this. What doesn't work:n/a Bug or feature?:n/a |
Changes
This removes the old keiko reports module.
QA notes
The code removed wasn't used anymore, so there should be no visible change.
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.