Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the keiko report module #4066

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Remove the keiko report module #4066

merged 3 commits into from
Feb 6, 2025

Conversation

dekkers
Copy link
Contributor

@dekkers dekkers commented Feb 6, 2025

Changes

This removes the old keiko reports module.

QA notes

The code removed wasn't used anymore, so there should be no visible change.


Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@dekkers dekkers requested a review from a team as a code owner February 6, 2025 08:32
@dekkers dekkers self-assigned this Feb 6, 2025
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good to me. I was just wondering why we still need the version module? Are there still references to keiko as a package?

@dekkers dekkers added this to the OpenKAT v1.18 milestone Feb 6, 2025
@dekkers
Copy link
Contributor Author

dekkers commented Feb 6, 2025

Nice work, looks good to me. I was just wondering why we still need the version module? Are there still references to keiko as a package?

This is used in the CI to build the debian package and container image so we still need it to build the empty package and image.

Copy link

sonarqubecloud bot commented Feb 6, 2025

@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

Seems to work. Can still export reports, not seeing errors in the logs. Couldn't find anything broken caused by this.

What doesn't work:

n/a

Bug or feature?:

n/a

@underdarknl underdarknl merged commit 477f5b0 into main Feb 6, 2025
27 checks passed
@underdarknl underdarknl deleted the remove-keiko branch February 6, 2025 19:26
jpbruinsslot added a commit that referenced this pull request Feb 11, 2025
* main:
  Add run-on to Boefje Setup page (#4061)
  Translations update from Hosted Weblate (#4046)
  Remove the keiko report module (#4066)
  Add one-off jobs for report scheduler (#4045)
  Report Task List (#4059)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants