Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip erroring ooi's in ooi_repository.py #4069

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

underdarknl
Copy link
Contributor

Add code to not crash the entire result set when objects could not be shoehorned into our current ooi models.

Changes

This Pr add's some code to optionally send an error instead of crash on database content that does not fit the current OOI models. These crashes have a ripple effect where services don't get any data (eg, rocky), or crash themselves.
Erroring ooi's will be skipped, and an error is logged in Octopoes_api.

Issue link

You have to create an issue to link to this PR. If this really is not possible, write a very detailed description here and add this PR to the project board directly.

Please add the link to the issue after "Closes".

Closes ...

Demo

image

QA notes

Please add some information for QA on how to test the newly created code.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Add code to not crash the entire result set when objects could not be shoehorned into our current ooi models.
@underdarknl underdarknl requested a review from a team as a code owner February 6, 2025 12:14
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
28.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@underdarknl
Copy link
Contributor Author

As discussed, Ill add an OOI like object to carry the errors (and the why) from the backend into the frontend.

@underdarknl underdarknl assigned underdarknl and ammar92 and unassigned ammar92 Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants