Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves bss permutation efficiently #318

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fakufaku
Copy link

@fakufaku fakufaku commented Jul 2, 2019

The current implementation of bss_eval exhaustively tests all permutations of sources which has factorial cost. It is possible to find the permutation in quadratic time using a minimum weight matching algorithm for bipartite graphs. This algorithm is implemented by the function scipy.optimize.linear_sum_assignment. A wrapper around the scipy function is added to handle possible infinite entries in the cost matrix.

I tried to run the tests, but got some errors due to missing files.

@craffel
Copy link
Collaborator

craffel commented Jul 2, 2019

Thanks! I remember this being brought up before but I can't find any reference to it.

@faroit @aliutkus any thoughts?

@fakufaku
Copy link
Author

fakufaku commented Jul 5, 2019

Hi @craffel , thanks for the reply! I've also started discussing this with @aliutkus here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants