Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More efficient chord validation #378

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

bmcfee
Copy link
Collaborator

@bmcfee bmcfee commented Mar 29, 2024

Pulling this change out of PR #377

The chord validator was compiling a monster regexp on each call, which is pretty wasteful. This PR just lifts that regexp precompilation up to the module so it can be reused. I belive this was the main inefficiency behind issue #341 .

There should be no functional changes here, so as long as it passes linting and CI I'm happy to merge.

@bmcfee bmcfee added this to the 0.8 milestone Mar 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.32%. Comparing base (7997fdf) to head (b44cb8a).
Report is 5 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   88.31%   88.32%   +0.01%     
==========================================
  Files          19       19              
  Lines        2875     2878       +3     
==========================================
+ Hits         2539     2542       +3     
  Misses        336      336              
Flag Coverage Δ
unittests 88.32% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmcfee bmcfee merged commit ca6d7b2 into mir-evaluation:main Apr 1, 2024
8 checks passed
@bmcfee bmcfee deleted the chord-validation-efficiency branch April 1, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants