Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer rely on joo_global_object #413

Merged
merged 1 commit into from
Feb 7, 2025
Merged

no longer rely on joo_global_object #413

merged 1 commit into from
Feb 7, 2025

Conversation

hhugo
Copy link
Contributor

@hhugo hhugo commented Nov 19, 2024

It's deprecated and will result in a warning with the next release of jsoo

@MisterDA
Copy link
Collaborator

MisterDA commented Feb 7, 2025

Does this need a lower or upper bound on jsoo?

@hhugo
Copy link
Contributor Author

hhugo commented Feb 7, 2025

You need js_of_ocaml-compiler >= 4.0.0 but you already have a lower bound set to 5.8

@MisterDA MisterDA merged commit f49a310 into mirage:main Feb 7, 2025
11 of 12 checks passed
@hhugo hhugo deleted the go branch February 7, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants