Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mediawiki/mediawiki-codesniffer requirement from 42.0.0 to 43.0.0 #73

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 29, 2024

Updates the requirements on mediawiki/mediawiki-codesniffer to permit the latest version.

Changelog

Sourced from mediawiki/mediawiki-codesniffer's changelog.

43.0.0 / 2024-01-29

New sniffs

  • Added the following sniffs from the PHPCSExtra standards: (Daimona Eaytoy)
    • Universal.Constants.LowercaseClassResolutionKeyword: Enforce lowercase ::class
    • Universal.Constants.UppercaseMagicConstants: Enforce uppercase magic constants
    • Universal.ControlStructures.DisallowAlternativeSyntax: Disallow alternative PHP syntax
    • Universal.Lists.DisallowLongListSyntax: Disallow the long list()syntax
    • Universal.Operators.TypeSeparatorSpacing: Forbid spaces in union and intersection types
    • Universal.UseStatements.KeywordSpacing: Enforce a single space around keywords in use statements
    • Universal.UseStatements.LowercaseFunctionConst: Enforce lowercase function and const in use statements
    • Universal.UseStatements.NoUselessAliases: Forbids aliases in use statements where the alias is the same as the original name
    • Universal.WhiteSpace.CommaSpacing: Enforce correct spacing around commas

Changed sniffs

  • DeprecatedGlobalVariablesSniff: Add $wgCommandLineMode (Bartosz Dziewoński)
  • FunctionCommentSniff & PropertyDocumentationSniff: Allow array shapes in PHPDoc comments (thiemowmde)
  • FunctionCommentSniff: Require documentation of getters starting with "is", not only "get" (thiemowmde)
  • FunctionCommentSniff: Actually check if a method returns anything (thiemowmde)
  • FunctionAnnotationsSniff: Add @phan-type as an allowed annotation (Umherirrender)
  • FunctionAnnotationsSniff: Add @phan-side-effect-free as an allowed annotation (Bartosz Dziewoński)
  • LowerCamelFunctionsNameSniff: Ignore hook methods (DannyS712)
  • PhpunitAnnotationsSniff: Enforce absolute class path for coverage annotations (Func)

Removed sniffs

  • OneSpaceInlineArraySniff: Superseded by Universal.WhiteSpace.CommaSpacing
  • ShortListSyntaxSniff: Superseded by Universal.Lists.DisallowLongListSyntax
  • AlternativeSyntaxSniff: Superseded by Universal.ControlStructures.DisallowAlternativeSyntax

Documentation, dependencies and build changes

  • Run in parallel with 64 jobs by default (Kunal Mehta, Antoine Musso)
  • build: Allow composer/semver 3.4.0 as well as 3.3.2 (Reedy)
  • tests: Add test for awfully inconsistent code (Daimona Eaytoy)
  • build: Update squizlabs/PHP_CodeSniffer to 3.8.1 (Umherirrender)

42.0.0 / 2023-09-21

New sniffs

  • Create MockBoilerplateSniff for PHPUnit tests (DannyS712)
  • Create OneSpaceInlineArraySniff (Amir Sarabadani)
  • Create ShortListSyntaxSniff to replace list() by short array syntax (Umherirrender)
  • Enable Generic.WhiteSpace.ScopeIndent (Daimona Eaytoy)
  • Enable Squiz.ControlStructures.ControlSignature (Daimona Eaytoy)
  • Replace AssignmentInControlStructuresSniff with Generic.CodeAnalysis.AssignmentInCondition (Daimona Eaytoy)
  • Replace DisallowEmptyLineFunctionsSniff with Squiz.WhiteSpace.FunctionOpeningBraceSpace (Daimona Eaytoy)

Changed sniffs

  • AssertCountSniff: Prefer assertSameSize when both parts are count() (Func)
  • DeprecatedGlobalVariablesSniff: Add $wgHooks (Umherirrender)
  • ForbiddenFunctionsSniff: Fix not counting arguments correctly (Daimona Eaytoy)
  • SpaceAfterClosureSniff: Expand to enforce space after arrow functions (Umherirrender)

... (truncated)

Commits
  • c559bc0 HISTORY: Mark this as v43.0.0
  • 0ba5905 HISTORY: Add blended entry for 5351ea927 and 6927784cf
  • 645429d HISTORY: Add entry for 4861986b0
  • caeab67 HISTORY: Add entry for 9640c3255
  • 6927784 build: Update squizlabs/php_codesniffer to 3.8.1
  • 8c9cb70 Enforce absolute class path for coverage annotations
  • 4861986 composer.json: Allow newer composer/semver
  • 5351ea9 build: Update squizlabs/php_codesniffer to 3.8.0
  • 9640c32 Deprecate $wgCommandLineMode
  • 8b4eb65 LowerCamelFunctionsNameSniff: Ignore hook methods
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 29, 2024
@AgentIsai
Copy link
Contributor

@dependabot rebase

Updates the requirements on [mediawiki/mediawiki-codesniffer](https://github.com/wikimedia/mediawiki-tools-codesniffer) to permit the latest version.
- [Changelog](https://github.com/wikimedia/mediawiki-tools-codesniffer/blob/master/HISTORY.md)
- [Commits](wikimedia/mediawiki-tools-codesniffer@v42.0.0...v43.0.0)

---
updated-dependencies:
- dependency-name: mediawiki/mediawiki-codesniffer
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/composer/mediawiki/mediawiki-codesniffer-43.0.0 branch from 0c3c8d5 to 74a969e Compare February 19, 2024 03:43
@AgentIsai AgentIsai merged commit a33b908 into master Feb 19, 2024
0 of 2 checks passed
@AgentIsai AgentIsai deleted the dependabot/composer/mediawiki/mediawiki-codesniffer-43.0.0 branch February 19, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

1 participant