Feature/java15 #109 #116

spoltier · 2020-12-03T10:45:23Z

Closes #109 #105
Submitting this for review as I'm already pretty far along and would like some feedback.

🧾 Still trying to find out how to add a stable code coverage check. It appeared briefly when I changed the codecov YAML. Possibly it simply doesn't appear if no relevant R code is changed.
🤓 May add Windows if it's not too complicated (otherwise would do a follow-up PR)

Stub action as generated by github workflow starter

…va15-#109

riccardoporreca

@spoltier , see below some feedback, feel free to take any of it into account as part of this branch or for possible later refinements.

We should also replace the Travis badge in the README with the GH Actions one, but this can also be done on master after merging the PR

.github/workflows/ci-tests.yml

Co-authored-by: Riccardo Porreca <[email protected]>

owenfeehan · 2020-12-24T10:18:33Z

Dear @spoltier and @riccardoporreca,

Forgive the personal intrusion. I just noticed that we both seem to be exploring GitHub actions on the same day at the same time (I'm still getting updated from Mirai's GitHub activity it would seem).

Have fun! And a very merry Christmas and happy new year to you both.

spoltier · 2020-12-24T10:23:23Z

Dear @spoltier and @riccardoporreca,

Forgive the personal intrusion. I just noticed that we both seem to be exploring GitHub actions on the same day at the same time (I'm still getting updated from Mirai's GitHub activity it would seem).

Have fun! And a very merry Christmas and happy new year to you both.

Hi Owen,
Happy holidays to you as well 😃 Riccardo is already on his Christmas break, I was following up on some of his feedback from yesterday.
Have fun too!

spoltier added 30 commits December 3, 2020 10:06

#109 extend and document java check tolerance

fb03c86

#105 stub action

d289fe2

Stub action as generated by github workflow starter

Merge remote-tracking branch 'origin/gh-action-draft' into feature/ja…

0068775

…va15-#109

#105 WIP basic setup

5a9ff16

#105 activate for current branch

c566bf5

#105 use more recent setup R version

4bd1d25

#105 os matrix, javareconf

4062b8d

#105 javareconf as root

e515b0a

Install rJava from package manager

3411f23

#105 nonroot javareconf

9939364

#105 java debugging

e9950d4

#105 more java debugging

c50a373

#105 try r version 4 only

9904424

#105 debug PATH

625b8e8

#105 set vars for javareconf

578076c

#105 alternatives wrong flag syntax

2245058

#105 display javareconf output

9fbbc5b

#105 display javareconf output

661c8bb

#105 set vars before R install

bc38839

#105 remove preinstalled JVMs

06c23bb

issue #105 check java home path

688a036

#105 pass java home explicitly to javareconf

f1d8142

#105 remove java check, too severe

1590585

#105 add tinytex to build vignettes

4539a63

#105 no TeX, same check as travis

6601d69

#105 add changes from full example

fce8669

#105 param OS + version, skip vignettes

a1e137f

#105 skip vignettes in build

b034cf0

#105 upload if fail, check XLConnect pkg file

975fb78

#105 debug check, pkg file not as expected

fc84ed1

spoltier added 15 commits December 17, 2020 10:56

#105 clean after full tests

0c15ecc

#105 Windows

3d3e8f1

#105 typo in conditional

fea3b59

#105 windows: use cmd shell

c2d3997

#105 Windows: no javareconf >_<

3584b02

#105 windows: set pkg repo as quick fix

1bab4df

#105 Windows: check java version

0c0c0aa

#105 Java: both x64 and x86

019a0e3

#105 java x86 exception

d7fd116

#105 restrict to java x64 on macOS

b02c924

#105 abridged check witout multi archs

2a1f5d1

#105 single arch for full test suite

387e037

#105 temp: check windows only

8fed9b0

#105 reactivate others, multiarch except on win

d6f5ced

#105 typo in R conditional

997d38f

spoltier mentioned this pull request Dec 17, 2020

Check system dependencies using pkg manager #117

Merged

1 task

riccardoporreca approved these changes Dec 22, 2020

View reviewed changes

spoltier and others added 7 commits December 24, 2020 09:06

Update .github/workflows/ci-tests.yml

00b936c

Co-authored-by: Riccardo Porreca <[email protected]>

Apply suggestions from code review

bdf41dd

Co-authored-by: Riccardo Porreca <[email protected]>

#105 suggestions: coverage, artifact name

ab862ae

#105 full build on oldrel + devel

59a87b7

#105 quotes

90e676a

#105 readable artifact name

f0e0640

#105 disambiguate failure results artifact

e9f29b3

spoltier mentioned this pull request Dec 24, 2020

Review build matrix #119

Open

spoltier merged commit 2b8104c into master Dec 24, 2020

spoltier mentioned this pull request Feb 11, 2021

Switch to travis-ci.com #105

Closed

2 tasks

spoltier deleted the feature/java15-#109 branch April 3, 2023 17:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/java15 #109 #116

Feature/java15 #109 #116

spoltier commented Dec 3, 2020 •

edited

Loading

riccardoporreca left a comment

owenfeehan commented Dec 24, 2020

spoltier commented Dec 24, 2020

Feature/java15 #109 #116

Feature/java15 #109 #116

Conversation

spoltier commented Dec 3, 2020 • edited Loading

riccardoporreca left a comment

Choose a reason for hiding this comment

owenfeehan commented Dec 24, 2020

spoltier commented Dec 24, 2020

spoltier commented Dec 3, 2020 •

edited

Loading