Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Events section data model #116

Open
wants to merge 23 commits into
base: feat/resources
Choose a base branch
from
Open

Add Events section data model #116

wants to merge 23 commits into from

Conversation

pl-mnm
Copy link
Contributor

@pl-mnm pl-mnm commented Mar 3, 2025

image image

@pl-mnm pl-mnm requested a review from rungta March 3, 2025 11:06
rungta
rungta requested changes Mar 3, 2025
View reviewed changes
src/Module.php
$element = $event->sender;

// Only check elements in the include-list
$context = $element->section->handle . ':' . $element->type->handle;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Craft 5 some entries may not have a section, so $element->section->handle will thrown an error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please tell me how to replace it

Copy link
Member

@rungta rungta Mar 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

… = ($element->section->handle ?? '*') . ':' …

@pl-mnm pl-mnm requested a review from rungta March 4, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rungta rungta Awaiting requested review from rungta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pl-mnm @rungta