Update PHPDoc typing for PHPStan 2, adjust CI PHP versions

mishagp · Dec 15, 2024 · 2bbcac1 · 2bbcac1
1 parent f1c7f33
commit 2bbcac1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -9,7 +9,7 @@ jobs:
 
     strategy:
       matrix:
-        php-version: [ 8.0, 8.1, 8.2, 8.3 ]
+        php-version: [ 8.1, 8.2, 8.3, 8.4 ]
 
     steps:
       - name: Checkout Repository

diff --git a/src/Process.php b/src/Process.php
@@ -6,8 +6,19 @@
 
 class Process
 {
+    /**
+     * @var ?resource $stdin
+     */
     private mixed $stdin;
+
+    /**
+     * @var ?resource $stdout
+     */
     private mixed $stdout;
+
+    /**
+     * @var ?resource $stderr
+     */
     private mixed $stderr;
     private mixed $handle;
 
@@ -125,13 +136,13 @@ public function closeStdin(): void
     }
 
     /**
-     * @param resource $stream
+     * @param resource|null $stream
      */
     private function closeStream(&$stream): void
     {
-        if ($stream !== NULL) {
+        if (is_resource($stream) && get_resource_type($stream) === 'stream') {
             fclose($stream);
-            $stream = NULL;
+            $stream = null;
         }
     }
 }