Implement flexible parameters and add static constructor #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
============================================
+ Coverage 94.14% 94.59% +0.44%
- Complexity 69 76 +7
============================================
Files 3 3
Lines 205 222 +17
============================================
+ Hits 193 210 +17
Misses 12 12 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #3, wanted to add a simple and flexible API to configure commands.
I think the idea will be to add more structured, typed, param-specific implementations (i.e. the current thread limit config option) as requested/contributed but use the approach in this PR in the meantime. Also, it's not feasible to catch up with updates to
ocrmypdfand add really close integration to versioning there so this was always necessary.Also added a static constructor to make for cleaner overall syntax for usage.