feat(frontend/MkUrlPreview): support expanding ActivityPub notes #11478
+121
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #11478 +/- ##
===========================================
- Coverage 79.98% 79.92% -0.06%
===========================================
Files 954 956 +2
Lines 108806 109037 +231
Branches 8446 8452 +6
===========================================
+ Hits 87024 87147 +123
- Misses 21782 21890 +108 ☔ View full report in Codecov by Sentry. |
syuilo
reviewed
Sep 6, 2023
| @@ -80,12 +81,24 @@ const showContent = $ref(false); | |||
| padding: 0; | |||
| } | |||
|
|
|||
| .quoted { | |||
| margin: 8px 0; | |||
There was a problem hiding this comment.
コンポーネントのルート要素がmarginを持つのはデザイン上トラブルの元になるからやめたいかも
There was a problem hiding this comment.
ちょっといじってみたらmarginなくても良くなりました（postExpandedがtemplate使っていてMkNoteからのmarginが無視されている現象でした）
|
@syuilo この件、メンテされたら取り込む意思はありますか？ |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
APをサポートしているウェブリンクをノートとして展開できるように
Why
クリックしてページ開かなくてもいいようにしたいので
Additional info (optional)
Checklist