Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): 画像を投稿前にプレビュー可能に #15341

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

tai-cha
Copy link
Contributor

@tai-cha tai-cha commented Jan 25, 2025

What

投稿フォームに画像のプレビューを追加

image
image

Why

Close #15247

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jan 25, 2025
@tai-cha tai-cha changed the title Feat/show image feat(frontend): 画像をプレビュー可能に Jan 25, 2025
@tai-cha tai-cha changed the title feat(frontend): 画像をプレビュー可能に feat(frontend): 画像を投稿前にプレビュー可能に Jan 25, 2025
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 14.03509% with 98 lines in your changes missing coverage. Please review.

Project coverage is 18.82%. Comparing base (0a41e36) to head (83d2794).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...ges/frontend/src/components/MkImgPreviewDialog.vue 0.00% 57 Missing and 1 partial ⚠️
.../src/components/MkImgPreviewDialog.stories.impl.ts 0.00% 39 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15341       +/-   ##
============================================
- Coverage    38.77%   18.82%   -19.96%     
============================================
  Files         1601      766      -835     
  Lines       203902   111137    -92765     
  Branches      4011     1235     -2776     
============================================
- Hits         79065    20919    -58146     
+ Misses      124201    89629    -34572     
+ Partials       636      589       -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tai-cha
Copy link
Contributor Author

tai-cha commented Jan 25, 2025

Storybookも上げたので最新の背景はChromaticで

@tai-cha
Copy link
Contributor Author

tai-cha commented Jan 26, 2025

一応Chromaticから転載もしておきます
capture-209c166a.png

anatawa12 added a commit to anatawa12/misskey that referenced this pull request Jan 28, 2025
commit 83d2794
Author: taichan <[email protected]>
Date:   Mon Jan 27 10:23:18 2025 +0900

    Update packages/frontend/.storybook/generate.tsx

commit 842c745
Author: tai-cha <[email protected]>
Date:   Sat Jan 25 17:09:01 2025 +0900

    Add MkImgPreviewDialog to storybook generator

commit e1365fb
Author: tai-cha <[email protected]>
Date:   Sat Jan 25 17:02:37 2025 +0900

    backgroundのスタイル変更

    Co-authored-by: kakkokari-gtyih <[email protected]>

commit 4bb30a1
Author: tai-cha <[email protected]>
Date:   Sat Jan 25 16:59:32 2025 +0900

    Add storybook for MkImgPreviewDialog

commit c838f80
Author: tai-cha <[email protected]>
Date:   Sat Jan 25 16:43:25 2025 +0900

    消えてたのFix

commit b4842c0
Author: tai-cha <[email protected]>
Date:   Sat Jan 25 16:41:09 2025 +0900

    SPDX

commit 5b0aec5
Author: tai-cha <[email protected]>
Date:   Sat Jan 25 16:33:33 2025 +0900

    Update Changelog

commit ce787e4
Author: tai-cha <[email protected]>
Date:   Sat Jan 25 16:31:51 2025 +0900

    feat(client): 画像をプレビュー可能に
@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.1 milestone Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

投稿前に添付画像を確認できる機能
2 participants