Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): パスキーでパスワードレスログインが出来ない問題を修正 #15370

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

lqvp
Copy link
Contributor

@lqvp lqvp commented Jan 30, 2025

What

fix #14696
fix #15299

Why

正しいパスキーを使用しているにもかかわらず、ログインが出来ていなかった

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 18.83%. Comparing base (a3d236c) to head (0bcdd1f).
Report is 576 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/components/MkSignin.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15370       +/-   ##
============================================
- Coverage    41.74%   18.83%   -22.92%     
============================================
  Files         1549      764      -785     
  Lines       196555   111028    -85527     
  Branches      2767     1233     -1534     
============================================
- Hits         82055    20907    -61148     
+ Misses      113939    89534    -24405     
- Partials       561      587       +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mi-gh-maintainer mi-gh-maintainer bot merged commit 5840c7a into misskey-dev:develop Feb 4, 2025
22 checks passed
Copy link

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
1 participant