Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): ノートに対する仮想スクロール(実験的機能) #15373

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jan 31, 2025

What

MkNotesを仮想スクロールに対応させた

2025-01-31.19-18-56.1.mp4

実験的機能→skip note rendering→JS (Unstable) で有効化できる

image

Why

#6045

Additional info (optional)

  • パフォーマンスの測定などは行っていないが、うちの環境だとまともに測定できそうになかった(Misskeyの開発サーバーを起動しているだけでPCが重い)ので誰か測定してみてほしい気持ち

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 4.24710% with 248 lines in your changes missing coverage. Please review.

Project coverage is 18.79%. Comparing base (06f113b) to head (4da0dc7).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/components/MkNotes.vue 0.00% 157 Missing ⚠️
packages/frontend/src/components/MkNotes.note.vue 0.00% 65 Missing and 1 partial ⚠️
...ges/frontend/src/components/MkNotes.note.empty.vue 0.00% 13 Missing and 1 partial ⚠️
packages/frontend/src/pages/settings/other.vue 0.00% 8 Missing ⚠️
packages/frontend/src/pages/note.vue 0.00% 2 Missing ⚠️
packages/frontend/src/store.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15373       +/-   ##
============================================
- Coverage    40.38%   18.79%   -21.59%     
============================================
  Files         1607      766      -841     
  Lines       210127   111290    -98837     
  Branches      4081     1235     -2846     
============================================
- Hits         84852    20917    -63935     
+ Misses      124669    89784    -34885     
+ Partials       606      589       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Feb 1, 2025

汎用的な実装ではなく MkNotes オンリーにした理由はあるかしら(できればnotificationsとかもそうしたい)

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Feb 1, 2025

汎用的な実装ではなく MkNotes オンリーにした理由はあるかしら(できればnotificationsとかもそうしたい)

ノートの高さが最初に決定するタイミングまで待つ必要があった(→内部の読み込み完了時点でMkNotesにemitしている)ので一旦ノートのみで実装した

@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft February 1, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants