Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): remove X theme properties #15376

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Feb 1, 2025

What

Resolve #12601

Why

リファクタリング

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Feb 1, 2025
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 18.66%. Comparing base (c548ec9) to head (bf6d154).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ackages/frontend/src/components/MkAutocomplete.vue 0.00% 3 Missing ⚠️
...ges/frontend/src/components/MkUserSelectDialog.vue 0.00% 2 Missing ⚠️
...nd/src/pages/page-editor/page-editor.container.vue 0.00% 2 Missing ⚠️
packages/frontend/src/pages/admin/server-rules.vue 0.00% 1 Missing ⚠️
packages/frontend/src/widgets/WidgetCalendar.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #15376   +/-   ##
========================================
  Coverage    18.66%   18.66%           
========================================
  Files          766      766           
  Lines       111337   111337           
  Branches      1236     1236           
========================================
  Hits         20783    20783           
  Misses       89963    89963           
  Partials       591      591           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Feb 1, 2025

CSSのlight-darkを使うようになると、ダークモードの切り分けをCSSとJSの両方で管理する必要が出てきて後々煩雑になるかもしれない(ブラウザ側のオーバーライド等でこの部分だけが変になるなど)ので、テーマに基準色を置いてCSSのcolor関数等で透明度を調整するほうが良いかもしれない

@syuilo
Copy link
Member Author

syuilo commented Feb 1, 2025

ダークモードの切り分けをCSSとJSの両方で管理する必要はどうあがいても絶対に必要(ブラウザ側のUIに適用するにはCSSでブラウザ側にカラースキームを知らせる必要がある)だから諦めるしかなさそう

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Feb 1, 2025

ダークモードの切り分けをCSSとJSの両方で管理する必要はどうあがいても絶対に必要

それはそうだけど色の決定権がテーマ制御とCSSの記法の両方にあるのがなんか もやった(モヤる程度なので諦めても構わない)

@syuilo
Copy link
Member Author

syuilo commented Feb 1, 2025

テーマで全ての色を決定するという設計思想にはなっていないというのがあるわね(それをやろうとするとプロパティが膨大になるし、実装が煩雑になるため、重要度の高い色だけ設定可能にする)

@kakkokari-gtyih
Copy link
Contributor

まあそれはそうか

@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.1 milestone Feb 1, 2025
@mi-gh-maintainer mi-gh-maintainer bot merged commit cfb6128 into develop Feb 5, 2025
22 checks passed
Copy link

Thank you 🙏

@mi-gh-maintainer mi-gh-maintainer bot deleted the remove-x-theme-props branch February 5, 2025 11:17
harumaki2000 pushed a commit to harumaki2000/misskey-layp that referenced this pull request Feb 6, 2025
* refactor(frontend): remove X theme properties

* Update MkAutocomplete.vue

* Update WidgetCalendar.vue
DA-TENSHI pushed a commit to SHINANOSKEY-Projekt/SHINANOSKEY that referenced this pull request Feb 7, 2025
* refactor(frontend): remove X theme properties

* Update MkAutocomplete.vue

* Update WidgetCalendar.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

テーマのX系プロパティを削除
2 participants