Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): FreeBSDで起動できない問題を修正 #15418

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

What

  • @napi-rs/canvasがFreeBSDに対応していないためcanvasに変更
  • FreeBSDでの起動の障害となっていたクラスの参照を変更

Why

Fix #12764

Additional info (optional)

FreeBSDの環境がないので検証してない
https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/887 では起動できることが確認されている)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.12%. Comparing base (f3a4434) to head (710aa0b).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/misc/gen-identicon.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #15418   +/-   ##
========================================
  Coverage    42.12%   42.12%           
========================================
  Files         1609     1609           
  Lines       161803   161803           
  Branches      4083     4084    +1     
========================================
+ Hits         68161    68166    +5     
+ Misses       93194    93157   -37     
- Partials       448      480   +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mar0xy
Copy link
Contributor

Mar0xy commented Feb 7, 2025

For information about @napi-rs/canvas:

@napi-rs/canvas uses Skia which does not at all support FreeBSD OOTB without modifications/patching. See attached image from a Google dev saying that supporting FreeBSD is not planned.

image

@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.1 milestone Feb 14, 2025
@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

v2023.12.0 completely broken in FreeBSD
3 participants