Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: ga #15451

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

wip: ga #15451

wants to merge 9 commits into from

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Feb 11, 2025

What

Resolve #15426

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 8.42697% with 163 lines in your changes missing coverage. Please review.

Project coverage is 40.28%. Comparing base (e339293) to head (951f66c).

Files with missing lines Patch % Lines
packages/frontend/src/analytics.ts 0.00% 106 Missing and 1 partial ⚠️
...ges/frontend/src/pages/admin/external-services.vue 0.00% 39 Missing ⚠️
packages/frontend/src/boot/common.ts 0.00% 9 Missing ⚠️
...kend/src/server/api/endpoints/admin/update-meta.ts 14.28% 6 Missing ⚠️
...ges/backend/src/core/entities/MetaEntityService.ts 0.00% 1 Missing ⚠️
...ges/backend/src/server/api/endpoints/admin/meta.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15451      +/-   ##
===========================================
- Coverage    40.33%   40.28%   -0.06%     
===========================================
  Files         1611     1612       +1     
  Lines       210678   210842     +164     
  Branches      4083     4089       +6     
===========================================
- Hits         84972    84930      -42     
- Misses      125064   125300     +236     
+ Partials       642      612      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 11, 2025

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -9499,6 +9499,12 @@
                     "enableTestcaptcha": {
                       "type": "boolean"
                     },
+                    "googleAnalyticsMeasurementId": {
+                      "type": [
+                        "string",
+                        "null"
+                      ]
+                    },
                     "swPublickey": {
                       "type": [
                         "string",
@@ -10006,6 +10012,7 @@
                     "enableTurnstile",
                     "turnstileSiteKey",
                     "enableTestcaptcha",
+                    "googleAnalyticsMeasurementId",
                     "swPublickey",
                     "mascotImageUrl",
                     "bannerUrl",
@@ -17359,6 +17366,12 @@
                   "enableTestcaptcha": {
                     "type": "boolean"
                   },
+                  "googleAnalyticsMeasurementId": {
+                    "type": [
+                      "string",
+                      "null"
+                    ]
+                  },
                   "sensitiveMediaDetection": {
                     "type": "string",
                     "enum": [
@@ -83252,6 +83265,12 @@
           "enableTestcaptcha": {
             "type": "boolean"
           },
+          "googleAnalyticsMeasurementId": {
+            "type": [
+              "string",
+              "null"
+            ]
+          },
           "swPublickey": {
             "type": [
               "string",
@@ -83445,6 +83464,7 @@
           "enableTurnstile",
           "turnstileSiteKey",
           "enableTestcaptcha",
+          "googleAnalyticsMeasurementId",
           "swPublickey",
           "mascotImageUrl",
           "bannerUrl",

Get diff files from Workflow Page

@kakkokari-gtyih kakkokari-gtyih linked an issue Feb 11, 2025 that may be closed by this pull request
1 task
@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.1 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
Development

Successfully merging this pull request may close these issues.

GoogleAnalytics対応
2 participants