Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n wrapper to support CommonJS that was forgotten in d552fde #968

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

xhaggi
Copy link

@xhaggi xhaggi commented Apr 24, 2023

The i18n .wrapper.js was not updated to support CommonJS in d552fde. Without you can't import a translation file in a CommonJS environment.

Merge request checklist

  • I read the guidelines for contributing
  • I created my branch from dev and I am issuing the PR to dev
  • I didn't pushed the dist directory
  • Unit tests are OK
  • If it's a new feature, I added the necessary unit tests
  • If it's a new language, I filled the __locale and __author fields

@xhaggi
Copy link
Author

xhaggi commented Jun 26, 2024

@mistic100 it would be nice to see this MR merged for the next patch release. At the moment you can't import the i18n files e.g. import 'jQuery-QueryBuilder/dist/i18n/query-builder.de.js';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant