Accept pubkey connections in lit #434
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if you're the first person connecting to a node using --con, there is nobody who could have authenticated you, except via a local lit-af instance. This prevents two lit-af instances running on the same machine, as well as causing some sort of problem for people running multiple instances of lit on a single mahine
bolt compatibility stuff
still need to take care of other stuff to make sure that pubkey is used uniformly inside lit
delbonis
added
enhancement
|
Closed in favour of #437 |
Varunram
added a commit
to Varunram/lit
that referenced
this pull request
Dec 5, 2018
this is a combination of earlier PRs mit-dci#434 and mit-dci#435 with newer changes. With this PR, you must be able to 1. Connect to a remote lnd node and observe connection success 2. Connect remote lnd node to lit node for 15s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just accepting raw pk hashes, accept pubkeys as well so that we can connect using them. A small precursor to the bigger pubkey revamp that's coming. Requires #432 and builds upon one of its commit.