Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLC Subsystem. All the stuff below + Test + Add FeePerByte to the lit-af utility. #463

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

infografx
Copy link
Contributor

Added tests for:

Writing tests for the subsystem.
Creating arbitrarily large contracts.
Bug fixing at the ends of the interval.
Calculate the transactions vsizes.
Bug fixing when the counterparty runs the contract.

@infografx
Copy link
Contributor Author

If you have any questions. You are welcome.

@infografx
Copy link
Contributor Author

Or if you have comments or suggestions. Welcome.

@infografx
Copy link
Contributor Author

Also, I had updated a Python library "btcrpc" to "bitcoinrpc.authproxy"
because it is up-to-date and
it allows to study blockchain database more convenient.


import codecs

deb_mod = False
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this stand for "debug mode"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That would not print too much when it is not necessary.

import requests


from bitcoinrpc.authproxy import AuthServiceProxy, JSONRPCException
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I didn't just use bitcoinrpc originally is because I didn't want the testing framework to depend on external libraries, but if it's worth it then it's fine. You might want to remove that btcrpc now though.

@infografx
Copy link
Contributor Author

infografx commented Jul 25, 2019

Also I updated my other PR to work with this new test:
mit-dci/dlcoracle#5

It makes the oracle to publish a determined value.

@infografx
Copy link
Contributor Author

Now I'm continue to work on dlc test. It is necessary to add some cases to it.

@infografx infografx changed the title DLC Subsystem. All the stuff below + Test. Ready to merge to master branch. DLC Subsystem. All the stuff below + Test. Jul 25, 2019
@infografx
Copy link
Contributor Author

infografx commented Jul 25, 2019

Then I'm going to add FeesPerByte to the lit-af utility.
Because now it is broken.

@infografx infografx changed the title DLC Subsystem. All the stuff below + Test. DLC Subsystem. All the stuff below + Test + Add FeePerByte to the lit-af utility. Jul 26, 2019
@infografx
Copy link
Contributor Author

I have added a FeePerByte to the lit-af utility.

It looks like this milestone is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants