-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DLC Subsystem. All the stuff below + Test + Add FeePerByte to the lit-af utility. #463
base: master
Are you sure you want to change the base?
DLC Subsystem. All the stuff below + Test + Add FeePerByte to the lit-af utility. #463
Conversation
If you have any questions. You are welcome. |
Or if you have comments or suggestions. Welcome. |
Also, I had updated a Python library "btcrpc" to "bitcoinrpc.authproxy" |
|
||
import codecs | ||
|
||
deb_mod = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this stand for "debug mode"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. That would not print too much when it is not necessary.
import requests | ||
|
||
|
||
from bitcoinrpc.authproxy import AuthServiceProxy, JSONRPCException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I didn't just use bitcoinrpc originally is because I didn't want the testing framework to depend on external libraries, but if it's worth it then it's fine. You might want to remove that btcrpc
now though.
Also I updated my other PR to work with this new test: It makes the oracle to publish a determined value. |
Now I'm continue to work on dlc test. It is necessary to add some cases to it. |
Then I'm going to add FeesPerByte to the lit-af utility. |
I have added a FeePerByte to the lit-af utility. It looks like this milestone is completed. |
Added tests for:
Writing tests for the subsystem.
Creating arbitrarily large contracts.
Bug fixing at the ends of the interval.
Calculate the transactions vsizes.
Bug fixing when the counterparty runs the contract.