Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github workflows: add coveralls for test coverage reports #321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sloorush
Copy link
Contributor

@sloorush sloorush commented Sep 9, 2021

what it does

Add goveralls that gives reports on test coverage of the project.

how it does

Currently covering package accumulator.

It gives reports like this(below) on https://coveralls.io/
image
image

## Need suggestion on
Is there a better way to structure the workflows? Because right now, it runs the unit tests twice, which is not ideal or some way the job doesn't run out of memory.

edit: I found the issue of the Job getting cancelled, working on it
edit: work done

@sloorush sloorush force-pushed the add-coveralls branch 6 times, most recently from 62ef6c5 to 0c82223 Compare September 9, 2021 16:59
@sloorush sloorush marked this pull request as draft September 9, 2021 18:39
@sloorush sloorush force-pushed the add-coveralls branch 10 times, most recently from e3b768e to 1c991c9 Compare September 14, 2021 08:29
@sloorush sloorush marked this pull request as ready for review September 14, 2021 08:39
@sloorush
Copy link
Contributor Author

sloorush commented Sep 14, 2021

Ready for review!

@kcalvinalvin @adiabat Please take a look at it 😄

@kcalvinalvin
Copy link
Member

Most of the code is the same right? It's a bit hard to review since there's removed lines that turn this into a decently sized change. Could you add those back in to minimize the lines of change?

@sloorush sloorush force-pushed the add-coveralls branch 4 times, most recently from 0ea27cb to 169cd04 Compare September 16, 2021 04:35
@sloorush
Copy link
Contributor Author

sloorush commented Sep 16, 2021

Most of the code is the same right? It's a bit hard to review since there's removed lines that turn this into a decently sized change. Could you add those back in to minimize the lines of change?

YAML formatter suggested moving the steps by one indent ahead, so they were indented automatically
Shifted them back to the previous indent! 😄

@kcalvinalvin
Copy link
Member

Tested. Looks good 👍

@sloorush
Copy link
Contributor Author

@adiabat @kcalvinalvin, this PR can be merged. 😅

@kcalvinalvin
Copy link
Member

@adiabat @kcalvinalvin, this PR can be merged. 😅

I don't have merge access to this repo. @adiabat?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test coverage
2 participants