-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github workflows: add coveralls for test coverage reports #321
base: master
Are you sure you want to change the base?
Conversation
62ef6c5
to
0c82223
Compare
e3b768e
to
1c991c9
Compare
Ready for review! @kcalvinalvin @adiabat Please take a look at it 😄 |
Most of the code is the same right? It's a bit hard to review since there's removed lines that turn this into a decently sized change. Could you add those back in to minimize the lines of change? |
0ea27cb
to
169cd04
Compare
YAML formatter suggested moving the steps by one indent ahead, so they were indented automatically |
169cd04
to
06b752d
Compare
Tested. Looks good 👍 |
@adiabat @kcalvinalvin, this PR can be merged. 😅 |
I don't have merge access to this repo. @adiabat? |
what it does
Add goveralls that gives reports on test coverage of the project.
how it does
Currently covering package
accumulator
.It gives reports like this(below) on https://coveralls.io/
## Need suggestion onIs there a better way to structure the workflows? Because right now, it runs the unit tests twice, which is not ideal or some way the job doesn't run out of memory.
edit: I found the issue of the Job getting cancelled, working on itedit: work done