Minor fixes for the regular payment workflow #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should hopefully be cherry pick-able out into its own PR. Fixes for a few things that were problematic while getting stuff ready for refunds: - Zero-value baskets caused errors on checkout - the code was expecting to redirect, we need to send status back to the React app instead - import_product and update_product_data commands both didn't manage product versions correctly - for update_product_data, this fix is in the underlying API call that gets queued - refactored PendingOrder._get_or_create a bit to check to make sure the lines and versions match, or fail (and to move checking into a separate function to keep Ruff happy) - Added a BasketItem inline so you can see what's in the basket in Django Admin more easily
- Fix some tests with payment APIs - Add hard system link to Orders - we're doing this in Basket anyway
Open
cp-at-mit
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
mitodl/hq#6042
Description (What does it do?)
Fixes a few things that were noticed while working on refunds:
How can this be tested?
Automated tests should pass.
Importing or updating a product should properly create a version.
Opening a basket that has stuff in it in the Django Admin should also show you the items in the basket.
Checking out a basket that is zero value (i.e. with a 100% off discount) should result in a success status, not redirecting you to elsewhere.
If you try to check out with a product that doesn't have versions for whatever reason, it should fail. (In practice this shouldn't happen.)
New orders should have an associated IntegratedSystem.