-
Notifications
You must be signed in to change notification settings - Fork 65
KeyError fix on tram launch; ML Service class tidy-up #61
Conversation
Added caveat in Installation for anyone with multiple python interpreters
Applied fix from mitre-attack#61
Hello @jecarr and thank you for the substantive PR. Please accept my apologies that it has taken so long to respond. TRAM has been re-architected and moved to https://github.com/center-for-threat-informed-defense/tram, which unfortunately means that very little of this PR aligns to the new code base. From my review, it looks like most or all of the changes in this PR resolve issues with Dockerization, starting TRAM, and running TRAM. Those issues have all been addressed in the new TRAM. You can find instructions to download and run the docker container in the README.md file here https://github.com/center-for-threat-informed-defense/tram#installation. Hopefully the new TRAM is a benefit to you. I am happy to discuss further if you would like. Thank you! |
Closes #77
Closes #67
Closes #63
Closes #60
Closes #59
Closes #71 -> I haven't split this PR into multiple PRs because of overlapping fixes and PRs haven't been merged in a while
A quick check to see if a description is provided in an attack or not. Plus a little documentation on multiple python interpreters in README.
Notes:
Edit - I also noticed my target branch is
master
as opposed todevelop
(as requested in the Submission guidelines in above link) but at the time of writing, there is nodevelop
branchEdit - Updated PR to include fixes in ML service class and general tidy up. These include:
async def
is sufficient)with
statements)Whilst updating this PR, I've been checking similarities with others:
This initially was to fix queue issues but I see #52 exists - I believe this PR compliments that one and there is no overlap (@srbennett29, let me know if I'm wrong?)
This might also have overlap with #50 as I tried to spot PEP compliance and improve logging too - I'm happy to solve any merge conflicts if this gets merged later.
Edit - I'm not updating this PR anymore as the number of fixes have grown. If you are considering this PR (thanks!), I'd recommend creating a new one from a fork I have also been updating - here - which includes all the fixes this PR has. This is recommended to reduce conflicts.