Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate request headers are added(#244) #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KevinClair
Copy link

Fix duplicate request headers are added #244

@dsmiley
Copy link
Collaborator

dsmiley commented Nov 9, 2023

When does this problem happen? Could you add a test?

@KevinClair
Copy link
Author

When does this problem happen? Could you add a test?

We try to request a proxied URL and carry the cors request header. This problem causes the returned response to contain duplicate Access-Control-Allow-Origin request headers.

@dsmiley
Copy link
Collaborator

dsmiley commented Nov 9, 2023

I guess more specifically, is this a bug, or is it more of an improvement relating to user custom code?

@KevinClair
Copy link
Author

If you request a proxied url with 'CORS' request header, it's a bug what will cause problem. But if not, it's correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants