New Feature: Enable setting up Project visibility and Requesting access to a project #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty for user to request access or cancel request, ability for admins to accept/reject access requests Signed-off-by: Vanessa Fotso <[email protected]>
vanessuniq
added
enhancement
* Enable users with permissions to set up private slack channel for their projects/components and enable each user to set up direct slack notifications Signed-off-by: Vanessa Fotso <[email protected]> * Switch notifying users about error delivering slack notifications to logging the errors in the app logs Signed-off-by: Vanessa Fotso <[email protected]> * optimize user_mailer and associated views code Signed-off-by: Vanessa Fotso <[email protected]> * optimized the smtp notification workflow and updated to also notify users when membership updated or revoked Signed-off-by: Vanessa Fotso <[email protected]> * Refactored the slack workflow and updated to cover the review use case Signed-off-by: Vanessa Fotso <[email protected]> * Only project/component admins should be able to add/edit slackchannels Signed-off-by: Vanessa Fotso <[email protected]> * logic to determine which slack channel(s) should be notified Signed-off-by: Vanessa Fotso <[email protected]> * Setting default url for action mailer Signed-off-by: Vanessa Fotso <[email protected]> --------- Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
… for visibility changed, use badge to convey info Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
vanessuniq
requested review from
freddyfeelgood,
smarlaku820,
aaronlippold and
rlakey
There was a problem hiding this comment.
Hey Vanessa, a couple of comments/discussion points:
- On the Projects page, it looks like the alignment got changed to "center" for all the columns in the list. Can that be changed back to left-aligned?
- Also on the Projects page, my personal opinion regarding the "filter discoverable" checkbox would be to flip the functionality. Meaning, by default, show only "my" projects or projects I'm already a member of, and when the checkbox is checked, then either:
- Show all of my projects, and include the discoverable projects.
- Show only discoverable projects (make the checkbox more of a "toggle")
- Last comment - any thoughts (from anyone) on showing a more "generic" notification inside Vulcan regarding pending access requests? Meaning, maybe put an icon on the "Projects" menu link at the top that shows pending access requests (if I am an admin on any of the projects with access requests)? Reason being, if I don't have Slack or Email integration enabled, then the only way I'd know there were pending access requests is if I happen to actually open the project where the requests exist.
Otherwise everything looks great and seems to work as expected.
Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
|
Updated project's page filter, added notification bell on the top menu for pending requests.
|
|
Hey Vanessa, I'm good with how everything looks and functions, with one "future" caveat. When I have the toggles set to Show My Projects (but not the Discoverable ones), it doesn't show me all the projects I've been approved to be a member of. If I turn on the Discoverable toggle, then I see all projects and can go into the projects I am a member of. Maybe a future update? |
…r of regardless of wether it is discoverable or not Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following functionality to Vulcan:
Fix #590